chore(system-test): add tick log every second #2129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
32d1094
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a tick counter that logs every second in the system test server for monitoring and debugging purposes.
- Added
setIntervalin/examples/misc/system-test/src/shared/server.tsto log tick count every second - Potential memory leak risk as interval timer is not cleared on server exit
- Consider adding interval cleanup in server shutdown logic
- High frequency logging (1/sec) may impact performance in production environments
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+17
to
+21
| let tickIndex = 0; | ||
| setInterval(() => { | ||
| tickIndex++; | ||
| console.log("Tick", tickIndex); | ||
| }, 1000); |
There was a problem hiding this comment.
logic: No cleanup for setInterval. Store the interval ID and clear it when the server exits to prevent memory leaks.
Suggested change
| let tickIndex = 0; | |
| setInterval(() => { | |
| tickIndex++; | |
| console.log("Tick", tickIndex); | |
| }, 1000); | |
| let tickIndex = 0; | |
| const intervalId = setInterval(() => { | |
| tickIndex++; | |
| console.log("Tick", tickIndex); | |
| }, 1000); | |
| // Clear interval when process exits | |
| process.on('exit', () => clearInterval(intervalId)); |
This was referenced Mar 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the branch
03-06-fix_fix_connecting_to_clickhouse_from_edge_servers
graphite-app
bot
deleted the
03-06-chore_system-test_add_tick_log_every_second
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes