fix: get sqlite working on edge #2099
Closed
+1,099
−1,028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2025
Closed
Closed
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces concerning changes to SQLite database management in the Rivet system, primarily affecting temporary file handling and connection cleanup.
- Disabled garbage collection loop in
manager_gc_loopwith early return, preventing cleanup of expired connections - Commented out temporary SQLite file removal code in
SqliteConndrop handler - Added debug log message "foo" instead of proper file cleanup, indicating incomplete implementation
- These changes will cause temporary SQLite files to accumulate in the data directory over time
- Potential memory leak risk from disabled connection cleanup in
manager_gc_loop
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
MasterPtato
force-pushed
the
chore_wf_snapshot
branch
from
de2b0f9 to
204281c
Compare
Closed
NathanFlurry
force-pushed
the
03-03-fix_get_sqlite_working_on_edge
branch
from
d558db1 to
4c778c2
Compare
NathanFlurry
force-pushed
the
chore_wf_snapshot
branch
from
204281c to
2e186c6
Compare
MasterPtato
force-pushed
the
03-03-fix_get_sqlite_working_on_edge
branch
from
4c778c2 to
d558db1
Compare
MasterPtato
force-pushed
the
chore_wf_snapshot
branch
from
2e186c6 to
204281c
Compare
NathanFlurry
force-pushed
the
03-03-fix_get_sqlite_working_on_edge
branch
from
d558db1 to
4c778c2
Compare
NathanFlurry
force-pushed
the
chore_wf_snapshot
branch
from
204281c to
2e186c6
Compare
This was referenced Mar 6, 2025
MasterPtato
force-pushed
the
03-03-fix_get_sqlite_working_on_edge
branch
from
4c778c2 to
d558db1
Compare
MasterPtato
force-pushed
the
chore_wf_snapshot
branch
from
2e186c6 to
204281c
Compare
NathanFlurry
force-pushed
the
03-03-fix_get_sqlite_working_on_edge
branch
from
d558db1 to
4c778c2
Compare
NathanFlurry
force-pushed
the
chore_wf_snapshot
branch
from
204281c to
2e186c6
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes