fix: fix connecting to clickhouse from edge servers #2128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
794228f
|
| Status: | 🚫 Build failed. |
This was referenced Mar 6, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements TLS support for ClickHouse connections from edge servers with a temporary certificate validation bypass.
- Added
tokio-native-tlsdependency inpackages/common/pools/Cargo.tomlfor TLS connection handling - Modified
packages/common/pools/src/db/clickhouse.rsto use custom TLS configuration withdanger_accept_invalid_certs(temporary fix for RVT-4649) - Potential security concern: Using
unwrap()on TLS builder could cause runtime panics - Security risk: Accepting invalid certificates needs to be addressed before production deployment
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+23
to
+24
| .build() | ||
| .unwrap(); |
There was a problem hiding this comment.
logic: Replace unwrap() with proper error handling to prevent potential panics
Suggested change
| .build() | |
| .unwrap(); | |
| .build() | |
| .map_err(|e| Error::Global(Box::new(e)))?; |
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
Deploying rivet-hub with
|
| Latest commit: |
794228f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21e7a95e.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://03-06-fix-fix-connecting-to.rivet-hub-7jb.pages.dev |
Merge activity
|
graphite-app
bot
deleted the
03-06-fix_fix_connecting_to_clickhouse_from_edge_servers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RVT-4647