fix(fdb): conflict ranges #2063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
dc1d8cc
|
| Status: | 🚫 Build failed. |
This was referenced Feb 21, 2025
Deploying rivet with
|
| Latest commit: |
7b6ec47
|
| Status: | 🚫 Build failed. |
This was referenced Feb 21, 2025
Closed
This was referenced Feb 21, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes critical issues with FoundationDB transaction conflict range handling across multiple services and utilities in the Rivet platform.
- Added new
end_of_key_rangeutility function infdb-utilthat properly appends a 0 byte to end keys for single-key conflict ranges - Fixed lease expiration conflict detection in workflow engine by using proper end keys in
fdb_sqlite_nats/mod.rs - Updated port allocation conflict ranges in
ds/allocate_ingress_ports.rsto prevent concurrent allocation issues - Corrected client reservation conflict handling in Pegboard service to maintain data consistency during concurrent transactions
- Fixed allocation index update conflict ranges in Pegboard to ensure proper transaction isolation
8 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+84
to
+89
| pub fn end_of_key_range(key: &[u8]) -> Vec<u8> { | ||
| let mut end_key = Vec::with_capacity(key.len() + 1); | ||
| end_key.extend_from_slice(key); | ||
| end_key.push(0); | ||
| end_key | ||
| } |
There was a problem hiding this comment.
style: Consider using Vec::from(key) followed by push(0) for better readability and potentially better performance since it avoids an extra copy
MasterPtato
force-pushed
the
02-21-fix_fdb_conflict_ranges
branch
from
7b6ec47 to
403b5c7
Compare
MasterPtato
force-pushed
the
feat_add_basic_websocket_load_testing
branch
from
b2020df to
0e11e7a
Compare
This was referenced Mar 5, 2025
Closed
MasterPtato
force-pushed
the
02-21-fix_fdb_conflict_ranges
branch
from
c0ae31a to
dc1d8cc
Compare
Closed
NathanFlurry
force-pushed
the
02-21-fix_fdb_conflict_ranges
branch
from
dc1d8cc to
c3470c3
Compare
NathanFlurry
force-pushed
the
feat_add_basic_websocket_load_testing
branch
from
1ff560c to
745d6de
Compare
MasterPtato
force-pushed
the
02-21-fix_fdb_conflict_ranges
branch
from
c3470c3 to
dc1d8cc
Compare
NathanFlurry
force-pushed
the
02-21-fix_fdb_conflict_ranges
branch
from
dc1d8cc to
c3470c3
Compare
This was referenced Mar 6, 2025
MasterPtato
force-pushed
the
02-21-fix_fdb_conflict_ranges
branch
from
c3470c3 to
dc1d8cc
Compare
NathanFlurry
force-pushed
the
02-21-fix_fdb_conflict_ranges
branch
from
dc1d8cc to
c3470c3
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes