fix(system-test): fix isolates use of hono #2124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
a4a8905
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the system test implementation to properly integrate Hono's WebSocket functionality across both Deno and Node.js environments, with unified WebSocket handling and improved type safety.
- Modified
/examples/misc/system-test/src/isolate/main.tsto use Deno's WebSocket upgrader with proper KV API validation - Updated
/examples/misc/system-test/src/shared/server.tsto support both Deno and Node.js environments with unified WebSocket handling - Reduced resource allocation in
/examples/misc/system-test/tests/client.tsfrom 250/256 to 100 CPU/memory units for containers - Added Deno types in
/examples/misc/system-test/tsconfig.jsonfor proper type checking across runtimes - Changed build script path in
/examples/misc/system-test/rivet.jsoncto point to correct entry pointsrc/isolate/main.ts
8 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+14
to
+15
| "@types/deno": "^2.2.0", | ||
| "@types/node": "^22.13.9", |
There was a problem hiding this comment.
style: Using both @types/deno and @types/node could cause type conflicts since they may define overlapping globals differently
| import { createNodeWebSocket } from "@hono/node-ws"; | ||
| import { serve } from "@hono/node-server"; | ||
|
|
||
| let injectWebSocket: any; |
There was a problem hiding this comment.
style: avoid using 'any' type - should define proper type for injectWebSocket from @hono/node-ws
Comment on lines
+70
to
+71
| () => upgradeWebSocket, | ||
| ); |
There was a problem hiding this comment.
logic: upgradeWebSocket should be passed directly, not wrapped in an arrow function
Suggested change
| () => upgradeWebSocket, | |
| ); | |
| upgradeWebSocket, | |
| ); |
| // Setup auto-exit timer | ||
| setTimeout(() => { | ||
| console.error( | ||
| "Actor should've been destroyed by now. Automatically exiting.", | ||
| ); | ||
| exitFn(); | ||
| () => process.exit(1) |
There was a problem hiding this comment.
logic: The process.exit(1) call is wrapped in an arrow function that is never executed
Suggested change
| () => process.exit(1) | |
| process.exit(1) |
|
|
||
| // Add WebSocket endpoint with handler | ||
| let upgradeWebSocket = getUpgradeWebSocket(app); |
There was a problem hiding this comment.
style: let is used but the variable is never reassigned - should be const
MasterPtato
force-pushed
the
03-06-fix_system-test_fix_isolates_use_of_hono
branch
from
3424da5 to
ec9a121
Compare
NathanFlurry
force-pushed
the
03-06-fix_system-test_fix_isolates_use_of_hono
branch
from
ec9a121 to
a4a8905
Compare
NathanFlurry
force-pushed
the
docs_add_helm_rollback_troubleshooting_guide
branch
from
2dc32f4 to
a5ffea8
Compare
NathanFlurry
force-pushed
the
03-06-fix_system-test_fix_isolates_use_of_hono
branch
from
a4a8905 to
bc461e7
Compare
NathanFlurry
force-pushed
the
docs_add_helm_rollback_troubleshooting_guide
branch
from
a5ffea8 to
2537e7e
Compare
This was referenced Mar 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the branch
docs_add_helm_rollback_troubleshooting_guide
graphite-app
bot
deleted the
03-06-fix_system-test_fix_isolates_use_of_hono
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes