chore: add basic load test #2060

NathanFlurry · 2025-02-20T21:35:43Z

Changes

NathanFlurry · 2025-02-20T21:36:24Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

This PR introduces a comprehensive k6 load testing framework for WebSocket functionality in Rivet, with configurable parameters and actor management capabilities.

In /tests/load/basic/index.js, core WebSocket testing functionality is commented out, leaving only actor creation/destruction - this needs to be uncommented and implemented
/tests/load/basic/actor.js lacks proper timeout configuration in waitForHealth() function which could lead to hanging tests
/tests/load/basic/rivet_api.js only supports GET/POST methods, limiting test capabilities for DELETE operations
/tests/load/basic/rivet_api.js assumes all successful responses return 200 status code which may not handle 201/204 responses correctly
In /tests/load/basic/actor.js, WebSocket error handling doesn't include timeout scenarios or connection failures

_{5 file(s) reviewed, 6 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-20T21:36:20Z

justfile

+k6-run TEST:
+	k6 run --verbose tests/load/{{ TEST }}/index.js


style: k6-run command lacks explicit VU and iteration settings - could lead to unintended load on systems. Consider adding configurable parameters.

greptile-apps · 2025-02-20T21:36:20Z

tests/load/basic/index.js

+		//// Get endpoint info
+		//const port = actor.network.ports.http;
+		//const actorOrigin = `${port.protocol}://${port.hostname}:${port.port}${port.path ?? ""}`;
+		//
+		//// Wait for health check
+		//const isHealthy = waitForHealth(`${actorOrigin}/health`);
+		//if (!isHealthy) {
+		//    console.error('Health check failed');
+		//    return;
+		//}
+		//
+		//// Test WebSocket
+		//const wsUrl = `${actorOrigin}/ws`;
+		//testWebSocket(wsUrl);


logic: Core WebSocket testing functionality is commented out. Either uncomment and implement the tests, or remove the commented code if it's not needed.

greptile-apps · 2025-02-20T21:36:20Z

tests/load/basic/actor.js

+export function waitForHealth(url) {
+	let attempts = 0;
+	const maxAttempts = 30;
+
+	while (attempts < maxAttempts) {
+		const response = http.get(url);
+		if (response.status === 200) {
+			return true;
+		}
+		sleep(0.1);
+		attempts++;
+	}
+	return false;
+}


logic: Missing http import. waitForHealth will fail at runtime.

Suggested change

export function waitForHealth(url) {

let attempts = 0;

const maxAttempts = 30;

while (attempts < maxAttempts) {

const response = http.get(url);

if (response.status === 200) {

return true;

}

sleep(0.1);

attempts++;

}

return false;

}

import { check, sleep } from "k6";

import ws from "k6/ws";

import http from "k6/http";

import { callRivetApi } from "./rivet_api.js";

greptile-apps · 2025-02-20T21:36:21Z

tests/load/basic/actor.js

+			socket.on("error", () => {
+				reject(false);
+			});


style: Error handler should include error details in rejection for better debugging

greptile-apps · 2025-02-20T21:36:40Z

tests/load/basic/rivet_api.js

+
+		// Standard checks
+		const checks = {
+			"status is 200": (r) => r.status === 200,


logic: Status check is too strict. Some valid responses may use 201 (Created) or 204 (No Content).

Suggested change

"status is 200": (r) => r.status === 200,

"status is successful": (r) => r.status >= 200 && r.status < 300,

greptile-apps · 2025-02-20T21:36:40Z

tests/load/basic/rivet_api.js

+			fail(`${path} request failed`);
+		}
+
+		return JSON.parse(response.body);


style: Attempting to parse response body twice - once in check and once in return. Could cache the parsed result.

cloudflare-workers-and-pages · 2025-02-20T22:51:10Z

Deploying rivet with Cloudflare Pages

Latest commit:	`745d6de`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-02-21T05:17:16Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`745d6de`
Status:	✅ Deploy successful!
Preview URL:	https://86749208.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://feat-add-basic-websocket-loa.rivet-hub-7jb.pages.dev

View logs

graphite-app · 2025-03-06T03:33:11Z

Merge activity

Mar 5, 10:33 PM EST: A user added this pull request to the Graphite merge queue.
Mar 5, 10:35 PM EST: CI is running for this PR on a draft PR: #2125
Mar 5, 10:37 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #2125.

## Changes

MasterPtato mentioned this pull request Feb 20, 2025

fix: move actor state to fdb #2056

Closed

greptile-apps bot reviewed Feb 20, 2025

View reviewed changes

MasterPtato force-pushed the feat_add_support_for_JSON5/JSONC_config_files branch from 52486f4 to dc6cea5 Compare February 20, 2025 22:50

MasterPtato force-pushed the feat_add_basic_websocket_load_testing branch from 7171d0f to c7e13e3 Compare February 20, 2025 22:50

This was referenced Feb 20, 2025

fix(workflows): fix activity error backoff, in memory polling #2062

Closed

fix(fdb): conflict ranges #2063

Closed

MasterPtato force-pushed the feat_add_basic_websocket_load_testing branch from 0e11e7a to 1ff560c Compare March 5, 2025 20:55

feat: add basic websocket load testing

745d6de

MasterPtato mentioned this pull request Mar 5, 2025

fix: fix system test #2121

Closed

NathanFlurry force-pushed the feat_add_basic_websocket_load_testing branch from 1ff560c to 745d6de Compare March 5, 2025 23:56

NathanFlurry force-pushed the feat_add_support_for_JSON5/JSONC_config_files branch from 7b83adc to 4c23ff5 Compare March 5, 2025 23:56

NathanFlurry mentioned this pull request Mar 5, 2025

chore: bump version from 5.1.2 to 25.1.3 #2122

Closed

MasterPtato force-pushed the feat_add_support_for_JSON5/JSONC_config_files branch from 4c23ff5 to 7b83adc Compare March 6, 2025 00:50

MasterPtato force-pushed the feat_add_basic_websocket_load_testing branch from 745d6de to 1ff560c Compare March 6, 2025 00:50

NathanFlurry force-pushed the feat_add_basic_websocket_load_testing branch from 1ff560c to 745d6de Compare March 6, 2025 01:32

NathanFlurry force-pushed the feat_add_support_for_JSON5/JSONC_config_files branch from 7b83adc to 4c23ff5 Compare March 6, 2025 01:32

This was referenced Mar 6, 2025

docs: add helm rollback troubleshooting guide #2123

Closed

fix(system-test): fix isolates use of hono #2124

Closed

MasterPtato force-pushed the feat_add_support_for_JSON5/JSONC_config_files branch from 4c23ff5 to 7b83adc Compare March 6, 2025 02:38

MasterPtato force-pushed the feat_add_basic_websocket_load_testing branch from 745d6de to 1ff560c Compare March 6, 2025 02:38

NathanFlurry force-pushed the feat_add_basic_websocket_load_testing branch from 1ff560c to 745d6de Compare March 6, 2025 03:30

NathanFlurry force-pushed the feat_add_support_for_JSON5/JSONC_config_files branch from 7b83adc to 4c23ff5 Compare March 6, 2025 03:30

graphite-app bot pushed a commit that referenced this pull request Mar 6, 2025

chore: add basic load test (#2060)

85d01fa

 ## Changes

graphite-app bot closed this Mar 6, 2025

graphite-app bot deleted the feat_add_basic_websocket_load_testing branch March 6, 2025 03:37

github-actions bot mentioned this pull request Mar 6, 2025

chore(main): release 25.2.0 #2079

Merged

This was referenced Mar 6, 2025

chore: add some logs #2133

Closed

fix: fix wf change bug with client wf #2134

Closed

fix: fix topology units, core actor endpoints #2135

Closed

fix: fix pb draining #2136

Closed

fix(workflows): remove tagged signals from fdb driver #2137

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add basic load test #2060

chore: add basic load test #2060

NathanFlurry commented Feb 20, 2025

NathanFlurry commented Feb 20, 2025 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Feb 20, 2025

greptile-apps bot Feb 20, 2025

greptile-apps bot Feb 20, 2025

greptile-apps bot Feb 20, 2025

greptile-apps bot Feb 20, 2025

greptile-apps bot Feb 20, 2025

cloudflare-workers-and-pages bot commented Feb 20, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 21, 2025 •

edited

Loading

graphite-app bot commented Mar 6, 2025 •

edited

Loading

	"status is 200": (r) => r.status === 200,
	"status is successful": (r) => r.status >= 200 && r.status < 300,

chore: add basic load test #2060

chore: add basic load test #2060

Conversation

NathanFlurry commented Feb 20, 2025

Changes

NathanFlurry commented Feb 20, 2025 • edited Loading

How to use the Graphite Merge Queue

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Feb 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 20, 2025

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Feb 20, 2025 • edited Loading

Deploying rivet with Cloudflare Pages

cloudflare-workers-and-pages bot commented Feb 21, 2025 • edited Loading

Deploying rivet-hub with Cloudflare Pages

graphite-app bot commented Mar 6, 2025 • edited Loading

Merge activity

NathanFlurry commented Feb 20, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 20, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 21, 2025 •

edited

Loading

graphite-app bot commented Mar 6, 2025 •

edited

Loading