Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add timeout flag to docker-compose down #2048

Closed
wants to merge 1 commit into from
Closed

chore: add timeout flag to docker-compose down #2048

wants to merge 1 commit into from

Conversation

NathanFlurry
Copy link
Member

Changes

This was referenced Feb 19, 2025
Closed
Closed
This was referenced Feb 19, 2025
Closed
Closed
Closed
Closed
Closed
@MasterPtato MasterPtato mentioned this pull request Feb 19, 2025
Closed
This was referenced Feb 19, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Feb 19, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps[bot]
greptile-apps bot reviewed Feb 19, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added timeout flag to Docker Compose down command for immediate container shutdown in development environment.

  • Modified justfile to include -t 0 flag in dev-down command, ensuring containers stop immediately without waiting for graceful shutdown
  • Aligns dev-down behavior with existing dev-nuke command's timeout configuration

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@NathanFlurry NathanFlurry changed the base branch from 02-15-feat_workflows_abstract_debug_trait to graphite-base/2048 February 19, 2025 11:41
@NathanFlurry NathanFlurry mentioned this pull request Feb 19, 2025
Closed
@MasterPtato MasterPtato mentioned this pull request Feb 19, 2025
Closed
@MasterPtato MasterPtato force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from ebd711a to c85f6e8 Compare February 19, 2025 20:26
@MasterPtato MasterPtato changed the base branch from graphite-base/2048 to 02-19-feat_add_fdb_cli February 19, 2025 20:26
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 19, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8dddcab
Status:🚫  Build failed.

View logs

@MasterPtato MasterPtato mentioned this pull request Feb 20, 2025
Closed
@MasterPtato MasterPtato force-pushed the 02-19-feat_add_fdb_cli branch from 2a40375 to de4e0ee Compare February 20, 2025 01:56
@MasterPtato MasterPtato force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from c85f6e8 to fdf864b Compare February 20, 2025 01:56
@NathanFlurry NathanFlurry force-pushed the 02-19-feat_add_fdb_cli branch from de4e0ee to 7848def Compare February 20, 2025 02:28
@NathanFlurry NathanFlurry force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from fdf864b to 60ffaa2 Compare February 20, 2025 02:28
@MasterPtato MasterPtato force-pushed the 02-19-feat_add_fdb_cli branch from 7848def to de4e0ee Compare February 20, 2025 02:37
This was referenced Mar 5, 2025
Closed
Closed
@MasterPtato MasterPtato force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from 7dcc1c3 to befbb0b Compare March 5, 2025 20:55
@MasterPtato MasterPtato mentioned this pull request Mar 5, 2025
Closed
@NathanFlurry NathanFlurry force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from befbb0b to 8dddcab Compare March 5, 2025 23:56
@NathanFlurry NathanFlurry force-pushed the 02-19-feat_add_fdb_cli branch from 80ecdf3 to 6abf257 Compare March 5, 2025 23:56
@NathanFlurry NathanFlurry mentioned this pull request Mar 5, 2025
Closed
@MasterPtato MasterPtato force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from 8dddcab to befbb0b Compare March 6, 2025 00:50
@NathanFlurry NathanFlurry force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from befbb0b to 8dddcab Compare March 6, 2025 01:32
@NathanFlurry NathanFlurry force-pushed the 02-19-feat_add_fdb_cli branch from 80ecdf3 to 6abf257 Compare March 6, 2025 01:32
This was referenced Mar 6, 2025
Closed
Closed
@MasterPtato MasterPtato force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from 8dddcab to befbb0b Compare March 6, 2025 02:38
@NathanFlurry NathanFlurry force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from befbb0b to 8dddcab Compare March 6, 2025 03:30
@NathanFlurry NathanFlurry force-pushed the 02-19-feat_add_fdb_cli branch from 80ecdf3 to 6abf257 Compare March 6, 2025 03:30
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Mar 6, 2025 •
edited
Loading

Merge activity

  • Mar 5, 10:33 PM EST: A user added this pull request to the Graphite merge queue.
  • Mar 5, 10:35 PM EST: CI is running for this PR on a draft PR: #2125
  • Mar 5, 10:37 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #2125.

graphite-app bot pushed a commit that referenced this pull request Mar 6, 2025
@NathanFlurry
chore: add timeout flag to docker-compose down (#2048)
f9efe0e 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Mar 6, 2025
@graphite-app graphite-app bot deleted the chore_add_timeout_flag_to_docker-compose_down branch March 6, 2025 03:37
@github-actions github-actions bot mentioned this pull request Mar 6, 2025
Merged
This was referenced Mar 6, 2025
Closed
Closed
Closed
Closed
This was referenced Mar 6, 2025
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NathanFlurry