fix: fix system test #2121
Closed
fix: fix system test #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
f5b02de
|
| Status: | 🚫 Build failed. |
This was referenced Mar 5, 2025
Closed
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes system tests by updating script paths and adding timeout safeguards to prevent server spam in both container and isolate environments.
- Changed
ws-isolatescript path fromsrc/isolate/ws.tstosrc/isolate/main.tsinexamples/misc/system-test/rivet.jsonc - Added 1-minute auto-exit timeout in
examples/misc/system-test/src/container/main.tsto prevent accidental server spam - Added comprehensive KV API validation tests in
examples/misc/system-test/src/isolate/main.tsincluding put/get/delete and batch operations - Added consistent newline endings across multiple SDK package.json files for better maintainability
8 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
67
to
70
| if ((await ctx.kv.get(["batch", "a"])) !== null) { | ||
| throw new Error("kv deleteBatch failed - key still exists"); | ||
| } |
There was a problem hiding this comment.
style: Consider checking both keys a and b to ensure complete deletion
Suggested change
| if ((await ctx.kv.get(["batch", "a"])) !== null) { | |
| throw new Error("kv deleteBatch failed - key still exists"); | |
| } | |
| if ((await ctx.kv.get(["batch", "a"])) !== null || (await ctx.kv.get(["batch", "b"])) !== null) { | |
| throw new Error("kv deleteBatch failed - one or more keys still exist"); | |
| } |
NathanFlurry
changed the base branch from
03-04-chore_add_load_test_for_actor_lifecycle_containers
to
graphite-base/2121
This was referenced Mar 5, 2025
MasterPtato
force-pushed
the
03-05-fix_fix_system_test
branch
from
92c2d83 to
ffa323a
Compare
MasterPtato
force-pushed
the
graphite-base/2121
branch
from
653f5b7 to
3e07944
Compare
Deploying rivet-hub with
|
| Latest commit: |
f5b02de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2351c8e8.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://03-05-fix-fix-system-test.rivet-hub-7jb.pages.dev |
This was referenced Mar 6, 2025
Closed
Closed
MasterPtato
force-pushed
the
03-05-fix_fix_system_test
branch
from
ffa323a to
a746d0a
Compare
MasterPtato
changed the base branch from
graphite-base/2121
to
03-06-fix_system-test_fix_exiting_after_timeout_in_isolates
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
NathanFlurry
approved these changes
Mar 7, 2025
NathanFlurry
changed the base branch from
03-06-fix_system-test_fix_exiting_after_timeout_in_isolates
to
graphite-base/2121
MasterPtato
force-pushed
the
03-05-fix_fix_system_test
branch
from
a746d0a to
f5b02de
Compare
MasterPtato
force-pushed
the
graphite-base/2121
branch
from
6446ccd to
77bccb4
Compare
Closed
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes