fix(docker-compose): remove invalid health check from otel-collector #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-hub with
|
| Latest commit: |
9238740
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8962d4c5.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://03-06-fix-docker-compose-rem.rivet-hub-7jb.pages.dev |
Deploying rivet with
|
| Latest commit: |
9238740
|
| Status: | 🚫 Build failed. |
This was referenced Mar 6, 2025
This was referenced Mar 6, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removed invalid health check configuration from otel-collector service in docker-compose.yml, as the service health can be inferred through its dependencies and OTLP traffic handling.
- Removed health check testing endpoint
http://127.0.0.1:13133fromdocker/dev-full/docker-compose.ymlas it was pointing to an incorrect address - Service health is adequately monitored through dependency on clickhouse's health check and OTLP ports 4317/4318
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
…2127) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the branch
03-06-fix_ship_actor_logs_to_correct_clickhouse_database_table
graphite-app
bot
deleted the
03-06-fix_docker-compose_remove_invalid_health_check_from_otel-collector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes