Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): fix corepack not enabled error #2058

Closed
wants to merge 1 commit into from
Closed

fix(docker): fix corepack not enabled error #2058

wants to merge 1 commit into from
+2 −2

Conversation

NathanFlurry
Copy link
Member

Changes

This was referenced Feb 20, 2025
Closed
Closed
This was referenced Feb 20, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Feb 20, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Feb 20, 2025
Closed
greptile-apps[bot]
greptile-apps bot reviewed Feb 20, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed Corepack enablement issue in Docker builds by reordering Node.js installation steps in the universal Dockerfile.

  • Modified docker/universal/Dockerfile to properly sequence NodeSource repository addition before Node.js installation and Corepack enablement
  • Ensures consistent package management functionality across Docker environments

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 20, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2bc1dbc
Status: ✅  Deploy successful!
Preview URL: https://5ab7b5ee.rivet-hub-7jb.pages.dev
Branch Preview URL: https://02-19-fix-docker-fix-corepac.rivet-hub-7jb.pages.dev

View logs

@NathanFlurry NathanFlurry mentioned this pull request Feb 20, 2025
Closed
@MasterPtato MasterPtato force-pushed the 02-20-feat_workflows_implement_metrics_for_fdb_driver branch from 729d516 to c5b7bb3 Compare February 20, 2025 22:02
@MasterPtato MasterPtato mentioned this pull request Feb 20, 2025
Closed
@MasterPtato MasterPtato force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from 7f6cbbe to 22d17b8 Compare February 20, 2025 22:50
@MasterPtato MasterPtato changed the base branch from 02-20-feat_workflows_implement_metrics_for_fdb_driver to 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling February 20, 2025 22:50
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 20, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2bc1dbc
Status:🚫  Build failed.

View logs

This was referenced Mar 5, 2025
Closed
Closed
@MasterPtato MasterPtato force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from d9bf2f4 to cf49442 Compare March 5, 2025 20:55
@NathanFlurry
fix(docker): fix corepack not enabled error

Verified

This commit was signed with the committer’s verified signature.
NathanFlurry Nathan Flurry
GPG key ID: 5A997507F286F2D8
Verified
Learn about vigilant mode
Loading
Loading status checks…
2bc1dbc
@MasterPtato MasterPtato mentioned this pull request Mar 5, 2025
Closed
@NathanFlurry NathanFlurry force-pushed the 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling branch from 5dd5d3c to cc0d311 Compare March 5, 2025 23:56
@NathanFlurry NathanFlurry force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from cf49442 to 2bc1dbc Compare March 5, 2025 23:56
@NathanFlurry NathanFlurry mentioned this pull request Mar 5, 2025
Closed
@MasterPtato MasterPtato force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from 2bc1dbc to cf49442 Compare March 6, 2025 00:50
@NathanFlurry NathanFlurry force-pushed the 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling branch from 5dd5d3c to cc0d311 Compare March 6, 2025 01:32
@NathanFlurry NathanFlurry force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from cf49442 to 2bc1dbc Compare March 6, 2025 01:32
This was referenced Mar 6, 2025
Closed
Closed
@MasterPtato MasterPtato force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from 2bc1dbc to cf49442 Compare March 6, 2025 02:38
@NathanFlurry NathanFlurry force-pushed the 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling branch from 5dd5d3c to cc0d311 Compare March 6, 2025 03:30
@NathanFlurry NathanFlurry force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from cf49442 to 2bc1dbc Compare March 6, 2025 03:30
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Mar 6, 2025 •
edited
Loading

Merge activity

  • Mar 5, 10:33 PM EST: A user added this pull request to the Graphite merge queue.
  • Mar 5, 10:35 PM EST: CI is running for this PR on a draft PR: #2125
  • Mar 5, 10:37 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #2125.

graphite-app bot pushed a commit that referenced this pull request Mar 6, 2025
@NathanFlurry
fix(docker): fix corepack not enabled error (#2058)

Verified

This commit was signed with the committer’s verified signature.
NathanFlurry Nathan Flurry
GPG key ID: 6A5F43A4F3241BCA
Verified
Learn about vigilant mode
3dce130 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Mar 6, 2025
@graphite-app graphite-app bot deleted the 02-19-fix_docker_fix_corepack_not_enabled_error branch March 6, 2025 03:37
@github-actions github-actions bot mentioned this pull request Mar 6, 2025
Merged
This was referenced Mar 6, 2025
Closed
Closed
Closed
Closed
This was referenced Mar 6, 2025
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot]

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@NathanFlurry