Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeCov is not very optimistic, need to increase code coverage #22

Closed
tianliuliu opened this issue Mar 11, 2022 · 3 comments · Fixed by #96
Closed

codeCov is not very optimistic, need to increase code coverage #22

tianliuliu opened this issue Mar 11, 2022 · 3 comments · Fixed by #96
Assignees
@YxAc
Labels
good first issue Good for newcomers

Comments

@tianliuliu
Copy link
Contributor

in branch main codeCov 20%
need add code coverage
image
@ShannonDing ShannonDing added the good first issue Good for newcomers label Mar 11, 2022
@YxAc
Copy link
Contributor

YxAc commented Mar 25, 2022

I am interested in this and willing to enhance it for some time in the future，may I？

@tianliuliu
Copy link
Contributor Author

I am interested in this and willing to enhance it for some time in the future，may I？
YxAc，You are very welcomed to participate in the joint construction of rocketmq-mqtt !!!

@YxAc YxAc mentioned this issue Mar 30, 2022
Merged
This was referenced Apr 9, 2022
Closed
Closed
Merged
Merged
ShannonDing pushed a commit that referenced this issue Apr 11, 2022
@YxAc
codeCov for #22, add config and hook test for mqtt-cs (#62)
f5a8efa 
Co-authored-by: AhaThinking <[email protected]>
ShannonDing pushed a commit that referenced this issue Apr 11, 2022
@YxAc
code optimization and codeCov enhancing of mqtt.cs.protocol.mqtt.hand…
1393642 
…ler for #22 (#63)

Co-authored-by: AhaThinking <[email protected]>
@YxAc YxAc mentioned this issue Apr 16, 2022
Merged
ShannonDing pushed a commit that referenced this issue Apr 18, 2022
@YxAc
[ISSUE #22] codeCov of protocol.mqtt and protocol.rpc (#67)
eba371f 
* codeCov of protocol.mqtt and protocol.rpc for #22

* remove redundant 'TestConnectHandler'

Co-authored-by: AhaThinking <[email protected]>
This was referenced Apr 23, 2022
Merged
Open
tianliuliu added a commit that referenced this issue Apr 26, 2022
@tianliuliu
Merge pull request #82 from YxAc/continuously_improve_codeCov
011fbb3 
improving codeCov for #22
This was referenced Apr 30, 2022
Merged
Merged
tianliuliu added a commit that referenced this issue May 6, 2022
@tianliuliu
Merge pull request #90 from YxAc/improve_mqtt_cs_session_codeCov
0c20a2e 
[ISSUE #22] codeCov for mqtt.cs.session
tianliuliu added a commit that referenced this issue May 6, 2022
@tianliuliu
Merge pull request #89 from YxAc/improve_common_model_codeCov
ac90d5c 
[ISSUE #22] Improving codeCov for mqtt.common
@YxAc YxAc mentioned this issue May 15, 2022
Merged
pingww added a commit that referenced this issue May 20, 2022
@pingww
Merge pull request #96 from YxAc/codeCov_for_mqtt_ds
735e302 
[ISSUE #22] improving codeCov of mqtt.ds
@YxAc
Copy link
Contributor

YxAc commented May 20, 2022

Be happy that the problem is finally finished, :-), thanks @pingww

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YxAc YxAc

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #22] improving codeCov of mqtt.ds
3 participants
@YxAc @tianliuliu @ShannonDing