[ISSUE #22] improving codeCov of mqtt.ds #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YxAc
commented
May 15, 2022
| @@ -82,6 +82,11 @@ public void init() throws MQClientException { | |||
| }, 0, 5, TimeUnit.SECONDS); | |||
| } | |||
|
|
|||
| public void initMQAdminExt() throws MQClientException { | |||
YxAc
commented
May 15, 2022
| @@ -108,6 +113,9 @@ public void checkFirstTopicIfCreated(String firstTopic) { | |||
| } | |||
|
|
|||
| private void updateTopicRoute(String firstTopic) { | |||
| if (StringUtils.isBlank(firstTopic)) { | |||
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 44.04% 47.66% +3.61%
==========================================
Files 98 98
Lines 4200 4192 -8
Branches 656 655 -1
==========================================
+ Hits 1850 1998 +148
+ Misses 2016 1856 -160
- Partials 334 338 +4
Continue to review full report at Codecov.
|
YxAc
commented
May 15, 2022
| @@ -28,9 +28,13 @@ public class MqAdmin { | |||
| private DefaultMQAdminExt defaultMQAdminExt; | |||
|
|
|||
| public MqAdmin(Properties properties) { | |||
| this(properties.getProperty("NAMESRV_ADDR")); | |||
There was a problem hiding this comment.
add this constructor for optimizing MqFactory to reuse the same code block
YxAc
commented
May 15, 2022
| defaultMQPushConsumer.registerMessageListener((MessageListenerConcurrently) messageListener); | ||
| } | ||
| return defaultMQPushConsumer; | ||
| MqConsumer mqConsumer = new MqConsumer(properties, nameSrv); |
There was a problem hiding this comment.
reusing the same code block
YxAc
commented
May 15, 2022
| @RunWith(MockitoJUnitRunner.class) | ||
| public class TestOffsetStoreManager { | ||
| public class TestLmqOffsetStoreManager { |
tianliuliu
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuously fix #22