[ISSUE #22] Improving codeCov for mqtt.common #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YxAc
commented
Apr 30, 2022
| if (resource != null && resource.contains("%")) { | ||
| int firstIndex = resource.indexOf("%"); | ||
| if (resource != null && resource.contains(NAMESPACE_SPLITER)) { | ||
| int firstIndex = resource.indexOf(NAMESPACE_SPLITER); |
There was a problem hiding this comment.
using defined constant
YxAc
commented
Apr 30, 2022
| } else { | ||
| return null; | ||
| } | ||
| return splitNamespaceStr(topic); |
There was a problem hiding this comment.
encapsulate duplicate code block
YxAc
commented
Apr 30, 2022
| if (invoke.minRt.get() > rt) { | ||
| invoke.minRt.set(rt); | ||
| } | ||
| addInvoke(key, 1, rt, success); |
There was a problem hiding this comment.
reusing 'addInvoke' method
YxAc
commented
Apr 30, 2022
| @@ -31,7 +31,7 @@ public class TopicUtils { | |||
| * @return | |||
| */ | |||
| public static String normalizeTopic(String topic) { | |||
| if (topic == null) { | |||
| if (topic == null || topic.isEmpty()) { | |||
There was a problem hiding this comment.
may be use StringUtils.isBlank(topic) will be better
There was a problem hiding this comment.
may be use StringUtils.isBlank(topic) will be better
done
YxAc
commented
Apr 30, 2022
| return null; | ||
| } | ||
| if (mqttTopic.getSecondTopic() == null || mqttTopic.getFirstTopic() == null) { | ||
| if (!isP2P(mqttTopic.getSecondTopic())) { |
There was a problem hiding this comment.
reserve the order of 'null judgment' and 'p2p judgment'
|
Wonder under what conditions the codecov-commenter will be triggered？ @tianliuliu , thanks :-) |
it can be triggered always, sometimes it dosen't work, maybe the bug itself. |
tianliuliu
approved these changes
May 6, 2022
RongtongJin
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codeCov for mqtt.common to improving #22