improving codeCov for #22 #82
Conversation
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 30.35% 31.07% +0.72%
==========================================
Files 97 97
Lines 4191 4187 -4
Branches 661 660 -1
==========================================
+ Hits 1272 1301 +29
+ Misses 2676 2645 -31
+ Partials 243 241 -2
Continue to review full report at Codecov.
|
| do { | ||
| msgIdEntry.nextMsgId++; | ||
| if (msgIdEntry.nextMsgId > MAX_MSG_ID) { | ||
| msgIdEntry.nextMsgId = MIN_MSG_ID; | ||
| } | ||
| if (msgIdEntry.nextMsgId == startingMessageId) { | ||
| loopCount++; | ||
| if (loopCount >= maxLoopCount) { |
There was a problem hiding this comment.
i think this is not necessary, the if judgment will absolutely happen when the 'loopCount' plus
There was a problem hiding this comment.
Yes, it may be the case that maxLoopCount>1 was considered before
There was a problem hiding this comment.
in the old code, the var maxLoopCount=2, but it may be cause the getNextId become slow ,then hang the thread
There was a problem hiding this comment.
Under most cases, the method 'releaseId' which release 'inUseMsgIds' is enough, unless lots of message accumulation happens. Once the extreme case occurs, i think it makes no difference/sense to run the loop once or twice.
so may I remove the loop judgment and keep this change? @pingww @tianliuliu
There was a problem hiding this comment.
Under most cases, the method 'releaseId' which release 'inUseMsgIds' is enough, unless lots of message accumulation happens. Once the extreme case occurs, i think it makes no difference/sense to run the loop once or twice.
so may I remove the loop judgment and keep this change? @pingww @tianliuliu
you are right. the cause is exactly it.
continuously enhancing #22