[ISSUE #22] optimize code and codeCov enhancing of protocol.mqtt.handler #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YxAc
commented
Apr 10, 2022
| if (mqttConnectReturnCode == null) { | ||
| channelManager.closeConnect(channel, ChannelCloseFrom.SERVER, remark); | ||
| return; | ||
| } |
There was a problem hiding this comment.
remove the if judgment for #61
YxAc
commented
Apr 10, 2022
| channel.writeAndFlush(getMqttConnAckMessage(mqttConnectReturnCode)); | ||
| channelManager.closeConnect(channel, ChannelCloseFrom.SERVER, remark); | ||
| return; | ||
| } | ||
|
|
||
| CompletableFuture<Void> future = new CompletableFuture<>(); | ||
| ChannelInfo.setFuture(channel, ChannelInfo.FUTURE_CONNECT, future); | ||
|
|
||
| // use 'scheduler' to separate two i/o: 'ack to client' and 'session-load from rocketmq' |
There was a problem hiding this comment.
add comment for 'scheduler'
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 23.77% 26.34% +2.56%
==========================================
Files 96 96
Lines 4176 4171 -5
Branches 662 659 -3
==========================================
+ Hits 993 1099 +106
+ Misses 2960 2848 -112
- Partials 223 224 +1
Continue to review full report at Codecov.
|
YxAc
commented
Apr 10, 2022
| @Component | ||
| public class MqttPubRecHandler implements MqttPacketHandler<MqttMessage> { | ||
| private final MqttFixedHeader pubRelMqttFixedHeader = new MqttFixedHeader(MqttMessageType.PUBREL, false, | ||
| MqttQoS.AT_LEAST_ONCE, false, 0); |
There was a problem hiding this comment.
make fixHeader as private field to verify the correct 'qosLevel' in PUBREL header for unit test
YxAc
commented
Apr 10, 2022
|
|
||
| final boolean isQos2Message = isQos2Message(mqttMessage); | ||
| if (isQos2Message && !inFlyCache.contains(InFlyCache.CacheType.PUB, channelId, variableHeader.packetId())) { | ||
| inFlyCache.put(InFlyCache.CacheType.PUB, channelId, variableHeader.packetId()); |
There was a problem hiding this comment.
simplify the code block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code optimization and codeCov enhancing of mqtt.cs.protocol.mqtt.handler for #22