Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #22] codeCov for mqtt.cs.session #90

Merged
merged 4 commits into from
May 6, 2022
Merged

[ISSUE #22] codeCov for mqtt.cs.session #90

merged 4 commits into from
May 6, 2022

Conversation

YxAc
Copy link
Contributor

@YxAc YxAc commented May 1, 2022

continuously submit for #22

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #90 (29f9d47) into main (4f3f127) will increase coverage by 3.28%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   33.38%   36.66%   +3.28%     
==========================================
  Files          98       98              
  Lines        4233     4233              
  Branches      670      669       -1     
==========================================
+ Hits         1413     1552     +139     
+ Misses       2562     2396     -166     
- Partials      258      285      +27     
Impacted Files Coverage Δ
...he/rocketmq/mqtt/cs/session/infly/RetryDriver.java 64.36% <80.00%> (+24.25%) ⬆️
...a/org/apache/rocketmq/mqtt/cs/session/Session.java 52.89% <100.00%> (+13.04%) ⬆️
...he/rocketmq/mqtt/cs/session/match/MatchAction.java 72.61% <0.00%> (+22.61%) ⬆️
...che/rocketmq/mqtt/cs/session/infly/PushAction.java 57.89% <0.00%> (+27.36%) ⬆️
...rg/apache/rocketmq/mqtt/cs/session/QueueFresh.java 90.00% <0.00%> (+90.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3f127...29f9d47. Read the comment docs.

@@ -142,9 +142,7 @@ public Map<Subscription, Map<Queue, QueueOffset>> offsetMapSnapshot() {
}
Map<Queue, QueueOffset> queueMap = new HashMap<>(8);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the size 8 can be replaced by offsetMap.get(queueName).size()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the size 8 can be replaced by offsetMap.get(queueName).size()

good catch👍, done

@tianliuliu tianliuliu merged commit 0c20a2e into apache:main May 6, 2022
@YxAc YxAc deleted the improve_mqtt_cs_session_codeCov branch May 6, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants