-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #22] codeCov for mqtt.cs.session #90
Conversation
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 33.38% 36.66% +3.28%
==========================================
Files 98 98
Lines 4233 4233
Branches 670 669 -1
==========================================
+ Hits 1413 1552 +139
+ Misses 2562 2396 -166
- Partials 258 285 +27
Continue to review full report at Codecov.
|
@@ -142,9 +142,7 @@ public Map<Subscription, Map<Queue, QueueOffset>> offsetMapSnapshot() { | |||
} | |||
Map<Queue, QueueOffset> queueMap = new HashMap<>(8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the size 8 can be replaced by offsetMap.get(queueName).size()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the size 8 can be replaced by offsetMap.get(queueName).size()
good catch👍, done
continuously submit for #22