Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob in non-strict mode #226

Merged
merged 2 commits into from
Apr 18, 2020
Merged

Glob in non-strict mode #226

merged 2 commits into from
Apr 18, 2020

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Apr 18, 2020

Run glob in non-strict mode to recover from errors (e.g. permission issues).

Originally, it looked like we were already running in non-strict mode. But the documentation for node-glob could be made more clear (isaacs/node-glob#298).

Related: #224 #223 isaacs/node-glob#413

skovhus added 2 commits April 18, 2020 10:16
This allows directories without access to be on the given path.

E.g.  mkdir directory-without-access && sudo chown root:staff directory-without-access && sudo chmod 600 directory-without-access
@skovhus
Copy link
Collaborator Author

skovhus commented Apr 18, 2020

Upstream fix: isaacs/node-glob#413

@skovhus skovhus merged commit 10592d4 into master Apr 18, 2020
@skovhus skovhus deleted the glob-strict-mode branch April 18, 2020 08:38
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request May 27, 2020
Language server changelog:
1.16.1

    Fix brace expansion bug
(bash-lsp/bash-language-server#240)
    Do not crash if bash is not installed
(bash-lsp/bash-language-server#242)

1.16.0

    Improved completion handler for parameter expansions
(bash-lsp/bash-language-server#237)

1.15.0

    Use comments above symbols for documentation
(bash-lsp/bash-language-server#234,
bash-lsp/bash-language-server#235)

1.14.0

    onHover and onCompletion documentation improvements
(bash-lsp/bash-language-server#230)
    support 0/1 as values for HIGHLIGHT_PARSING_ERRORS
(bash-lsp/bash-language-server#231)

1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request May 27, 2020
Language server changelog:
1.16.1

    Fix brace expansion bug
(bash-lsp/bash-language-server#240)
    Do not crash if bash is not installed
(bash-lsp/bash-language-server#242)

1.16.0

    Improved completion handler for parameter expansions
(bash-lsp/bash-language-server#237)

1.15.0

    Use comments above symbols for documentation
(bash-lsp/bash-language-server#234,
bash-lsp/bash-language-server#235)

1.14.0

    onHover and onCompletion documentation improvements
(bash-lsp/bash-language-server#230)
    support 0/1 as values for HIGHLIGHT_PARSING_ERRORS
(bash-lsp/bash-language-server#231)

1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)


Signed-off-by: Alexander Kurtakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant