Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from file read errors #211

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Recover from file read errors #211

merged 3 commits into from
Apr 14, 2020

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Apr 14, 2020

If reading a file fails, the LSP crashes. This means that we do not handle broken symlinks and other corner cases – let us do that.

Fixes #202

@skovhus skovhus force-pushed the handle-broken-symlinks branch from fe9e0b4 to 4d3ea28 Compare April 14, 2020 18:42
@skovhus skovhus force-pushed the handle-broken-symlinks branch from 4d3ea28 to 52041dc Compare April 14, 2020 18:54
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #211 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   69.91%   70.04%   +0.12%     
==========================================
  Files          18       18              
  Lines         472      474       +2     
  Branches       68       68              
==========================================
+ Hits          330      332       +2     
  Misses        125      125              
  Partials       17       17              
Impacted Files Coverage Δ
server/src/analyser.ts 73.07% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a356f...52041dc. Read the comment docs.

@skovhus skovhus merged commit f11f305 into master Apr 14, 2020
@skovhus skovhus deleted the handle-broken-symlinks branch April 14, 2020 18:56
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENOENT error on broken symbolic links
1 participant