Recover from file read errors #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovhus
force-pushed
the
handle-broken-symlinks
branch
from
fe9e0b4 to
4d3ea28
Compare
skovhus
force-pushed
the
handle-broken-symlinks
branch
from
4d3ea28 to
52041dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 69.91% 70.04% +0.12%
==========================================
Files 18 18
Lines 472 474 +2
Branches 68 68
==========================================
+ Hits 330 332 +2
Misses 125 125
Partials 17 17
Continue to review full report at Codecov.
|
akurtakov
added a commit
to akurtakov/shellwax
that referenced
this pull request
Apr 21, 2020
Changelog of the server:
1.13.1
Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)
1.13.0
Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)
1.12.0
Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)
1.11.3
Recover from file reading errors
(bash-lsp/bash-language-server#211)
Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov
added a commit
to akurtakov/shellwax
that referenced
this pull request
Apr 21, 2020
Changelog of the server:
1.13.1
Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)
1.13.0
Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)
1.12.0
Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)
1.11.3
Recover from file reading errors
(bash-lsp/bash-language-server#211)
Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov
added a commit
to eclipse-shellwax/shellwax
that referenced
this pull request
Apr 21, 2020
Changelog of the server:
1.13.1
Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)
1.13.0
Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)
1.12.0
Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)
1.11.3
Recover from file reading errors
(bash-lsp/bash-language-server#211)
Signed-off-by: Alexander Kurtakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If reading a file fails, the LSP crashes. This means that we do not handle broken symlinks and other corner cases – let us do that.
Fixes #202