Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion improvements: workspace symbols & executables #215

Merged
merged 7 commits into from
Apr 16, 2020

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Apr 16, 2020

Completion handler improvements:

  • symbols from other files are now also used (both variables and functions for now – we could consider limiting this), but we prefer local symbols if we have duplicates
  • symbol completions from other files utilize the documentation feature to show where the symbol comes from
  • remove duplicated completions for executables and builtins (e.g. echo is both a builtin AND have a man page)
  • ensure that executable programs on the paths are actually executable

@skovhus skovhus force-pushed the completion-across-workspace branch from c8db938 to b149858 Compare April 16, 2020 11:56
@skovhus skovhus marked this pull request as draft April 16, 2020 11:56
@skovhus skovhus changed the title [WIP] Completion across workspace WIP: Completion across workspace Apr 16, 2020
@skovhus skovhus force-pushed the completion-across-workspace branch 5 times, most recently from da708dd to 72835f7 Compare April 16, 2020 12:40
@skovhus skovhus changed the title WIP: Completion across workspace Completion improvements: workspace symbols Apr 16, 2020
@skovhus skovhus force-pushed the completion-across-workspace branch from 72835f7 to f195be5 Compare April 16, 2020 13:08
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #215 into master will increase coverage by 1.49%.
The diff coverage is 64.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   70.16%   71.65%   +1.49%     
==========================================
  Files          18       18              
  Lines         476      494      +18     
  Branches       68       71       +3     
==========================================
+ Hits          334      354      +20     
+ Misses        125      122       -3     
- Partials       17       18       +1     
Impacted Files Coverage Δ
server/src/util/fs.ts 75.00% <ø> (+1.31%) ⬆️
server/src/server.ts 57.14% <52.17%> (-3.07%) ⬇️
server/src/analyser.ts 83.33% <85.71%> (+9.91%) ⬆️
server/src/executables.ts 88.88% <85.71%> (+13.13%) ⬆️
server/src/util/array.ts 83.33% <0.00%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2405e2c...ab50f7d. Read the comment docs.

@skovhus skovhus force-pushed the completion-across-workspace branch from c9c0ad6 to 61b4b69 Compare April 16, 2020 18:02
@skovhus skovhus changed the title Completion improvements: workspace symbols Completion improvements: workspace symbols & executables Apr 16, 2020
@skovhus skovhus marked this pull request as ready for review April 16, 2020 19:14
@skovhus skovhus merged commit f0211cc into master Apr 16, 2020
@skovhus skovhus deleted the completion-across-workspace branch April 16, 2020 19:50
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant