Fix brace expansion bug #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-skobov
force-pushed
the
fix-brace-expansion-bug
branch
from
44c686f to
e7bd78b
Compare
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 73.30% 73.40% +0.09%
==========================================
Files 18 18
Lines 547 549 +2
Branches 87 88 +1
==========================================
+ Hits 401 403 +2
Misses 126 126
Partials 20 20
Continue to review full report at Codecov.
|
|
oops. first push had my merges from master into my fork, and also it failed one of the tests, I fixed it. @skovhus ready for review. |
skovhus
reviewed
May 22, 2020
nikita-skobov
force-pushed
the
fix-brace-expansion-bug
branch
from
e7bd78b to
4b279a9
Compare
skovhus
approved these changes
May 22, 2020
nikita-skobov
force-pushed
the
fix-brace-expansion-bug
branch
from
4b279a9 to
2dafe3b
Compare
|
@nikita-skobov another great PR! Thanks for helping out 🤩 |
akurtakov
added a commit
to akurtakov/shellwax
that referenced
this pull request
May 27, 2020
Language server changelog:
1.16.1
Fix brace expansion bug
(bash-lsp/bash-language-server#240)
Do not crash if bash is not installed
(bash-lsp/bash-language-server#242)
1.16.0
Improved completion handler for parameter expansions
(bash-lsp/bash-language-server#237)
1.15.0
Use comments above symbols for documentation
(bash-lsp/bash-language-server#234,
bash-lsp/bash-language-server#235)
1.14.0
onHover and onCompletion documentation improvements
(bash-lsp/bash-language-server#230)
support 0/1 as values for HIGHLIGHT_PARSING_ERRORS
(bash-lsp/bash-language-server#231)
1.13.1
Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)
Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov
added a commit
to eclipse-shellwax/shellwax
that referenced
this pull request
May 27, 2020
Language server changelog:
1.16.1
Fix brace expansion bug
(bash-lsp/bash-language-server#240)
Do not crash if bash is not installed
(bash-lsp/bash-language-server#242)
1.16.0
Improved completion handler for parameter expansions
(bash-lsp/bash-language-server#237)
1.15.0
Use comments above symbols for documentation
(bash-lsp/bash-language-server#234,
bash-lsp/bash-language-server#235)
1.14.0
onHover and onCompletion documentation improvements
(bash-lsp/bash-language-server#230)
support 0/1 as values for HIGHLIGHT_PARSING_ERRORS
(bash-lsp/bash-language-server#231)
1.13.1
Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)
Signed-off-by: Alexander Kurtakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #239
Please let me know if there's a better way than my
validCompletions.filterapproach.