Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brace expansion bug #240

Merged
merged 2 commits into from
May 23, 2020

Conversation

nikita-skobov
Copy link
Contributor

as described in #239

Please let me know if there's a better way than my validCompletions.filter approach.

@nikita-skobov nikita-skobov force-pushed the fix-brace-expansion-bug branch from 44c686f to e7bd78b Compare May 21, 2020 01:32
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #240 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   73.30%   73.40%   +0.09%     
==========================================
  Files          18       18              
  Lines         547      549       +2     
  Branches       87       88       +1     
==========================================
+ Hits          401      403       +2     
  Misses        126      126              
  Partials       20       20              
Impacted Files Coverage Δ
server/src/server.ts 62.13% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016291a...4b279a9. Read the comment docs.

@nikita-skobov
Copy link
Contributor Author

oops. first push had my merges from master into my fork, and also it failed one of the tests, I fixed it. @skovhus ready for review.

@nikita-skobov nikita-skobov marked this pull request as ready for review May 21, 2020 15:33
@nikita-skobov nikita-skobov force-pushed the fix-brace-expansion-bug branch from e7bd78b to 4b279a9 Compare May 22, 2020 15:06
@nikita-skobov nikita-skobov force-pushed the fix-brace-expansion-bug branch from 4b279a9 to 2dafe3b Compare May 22, 2020 19:47
@skovhus
Copy link
Collaborator

skovhus commented May 23, 2020

@nikita-skobov another great PR! Thanks for helping out 🤩

@skovhus skovhus merged commit b3e84fb into bash-lsp:master May 23, 2020
akurtakov added a commit to akurtakov/shellwax that referenced this pull request May 27, 2020
Language server changelog:
1.16.1

    Fix brace expansion bug
(bash-lsp/bash-language-server#240)
    Do not crash if bash is not installed
(bash-lsp/bash-language-server#242)

1.16.0

    Improved completion handler for parameter expansions
(bash-lsp/bash-language-server#237)

1.15.0

    Use comments above symbols for documentation
(bash-lsp/bash-language-server#234,
bash-lsp/bash-language-server#235)

1.14.0

    onHover and onCompletion documentation improvements
(bash-lsp/bash-language-server#230)
    support 0/1 as values for HIGHLIGHT_PARSING_ERRORS
(bash-lsp/bash-language-server#231)

1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request May 27, 2020
Language server changelog:
1.16.1

    Fix brace expansion bug
(bash-lsp/bash-language-server#240)
    Do not crash if bash is not installed
(bash-lsp/bash-language-server#242)

1.16.0

    Improved completion handler for parameter expansions
(bash-lsp/bash-language-server#237)

1.15.0

    Use comments above symbols for documentation
(bash-lsp/bash-language-server#234,
bash-lsp/bash-language-server#235)

1.14.0

    onHover and onCompletion documentation improvements
(bash-lsp/bash-language-server#230)
    support 0/1 as values for HIGHLIGHT_PARSING_ERRORS
(bash-lsp/bash-language-server#231)

1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)


Signed-off-by: Alexander Kurtakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants