Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize build setup #225

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Modernize build setup #225

merged 1 commit into from
Apr 17, 2020

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Apr 17, 2020

This is based on https://github.com/microsoft/vscode-extension-samples/tree/e1ecdaec8974b938e7a92589faa233e1691d251f/lsp-sample

Limitations with the old setup:

  • hard to add tests for the client (tsconfig madness)
  • running locally: debugger doesn't work with server
  • running locally: we are not compiling in watch mode, so it is fairly slow

@skovhus skovhus merged commit 08ae8de into master Apr 17, 2020
@skovhus skovhus deleted the update-build branch April 17, 2020 19:56
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
@akurtakov
Update to use Bash LS 1.13.0
9a6214c 
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
@akurtakov
Update to use Bash LS 1.13.0
d25381d 
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request Apr 21, 2020
@akurtakov
Update to use Bash LS 1.13.0
5174634 
Changelog of the server:
1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)

1.13.0

    Upgrade vscode-languageserver from 5 to 6
(bash-lsp/bash-language-server#217)

1.12.0

    Completion handler improvements: remove duplicates, include symbols
from other files, ensure that programs found on the paths are actually
executable (bash-lsp/bash-language-server#215)

1.11.3

    Recover from file reading errors
(bash-lsp/bash-language-server#211)


Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request May 27, 2020
@akurtakov
Update to Bash LS 1.16.1
e6ff77d 
Language server changelog:
1.16.1

    Fix brace expansion bug
(bash-lsp/bash-language-server#240)
    Do not crash if bash is not installed
(bash-lsp/bash-language-server#242)

1.16.0

    Improved completion handler for parameter expansions
(bash-lsp/bash-language-server#237)

1.15.0

    Use comments above symbols for documentation
(bash-lsp/bash-language-server#234,
bash-lsp/bash-language-server#235)

1.14.0

    onHover and onCompletion documentation improvements
(bash-lsp/bash-language-server#230)
    support 0/1 as values for HIGHLIGHT_PARSING_ERRORS
(bash-lsp/bash-language-server#231)

1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)


Signed-off-by: Alexander Kurtakov <[email protected]>
@akurtakov akurtakov mentioned this pull request May 27, 2020
Merged
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request May 27, 2020
@akurtakov
Update to Bash LS 1.16.1
d2a6972 
Language server changelog:
1.16.1

    Fix brace expansion bug
(bash-lsp/bash-language-server#240)
    Do not crash if bash is not installed
(bash-lsp/bash-language-server#242)

1.16.0

    Improved completion handler for parameter expansions
(bash-lsp/bash-language-server#237)

1.15.0

    Use comments above symbols for documentation
(bash-lsp/bash-language-server#234,
bash-lsp/bash-language-server#235)

1.14.0

    onHover and onCompletion documentation improvements
(bash-lsp/bash-language-server#230)
    support 0/1 as values for HIGHLIGHT_PARSING_ERRORS
(bash-lsp/bash-language-server#231)

1.13.1

    Gracefully handle glob failures
(bash-lsp/bash-language-server#224,
bash-lsp/bash-language-server#226)
    Maintenance
(bash-lsp/bash-language-server#222,
bash-lsp/bash-language-server#225)


Signed-off-by: Alexander Kurtakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skovhus