-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tvOS] Update ConnectToServerView & UserSignInView #1365
Conversation
Swiftfin tvOS/Views/UserSignInView/Components/PublicUserButton.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm moving away from the pattern of functions on views that supply the content through () -> any View
, at least where the views aren't actually customizable and should be using generics instead.
These views still have some work that can be done like having the server splash screen on the background of UserSignInView
as well as some design refinements.
* upstream/main: (392 commits) [tvOS] Add pin prompt to sign-in screen (jellyfin#1383) [iOS] Admin Dashboard - User Access Tags (jellyfin#1377) [Meta] 2025 Disclaimer (jellyfin#1381) [tvOS] Delete User from User Selection Screen (jellyfin#1359) [iOS] Media Item Menu - Identify Media Item (jellyfin#1369) [iOS] Admin Dashboard - User Profiles (jellyfin#1328) [iOS] Select all Users When Editing (jellyfin#1373) [Meta] Automatic String Organization (jellyfin#1372) [iOS & tvOS] Unused Localization Cleanup (jellyfin#1362) [tvOS] SelectServerView Change to Menu (jellyfin#1363) [tvOS] Update ConnectToServerView & UserSignInView (jellyfin#1365) Trim Fastlane Options (jellyfin#1367) Update Fastlane Runner (jellyfin#1366) [iOS & tvOS] Localize Existing Strings (jellyfin#1361) [iOS] Admin Dashboard - User Access Schedules (jellyfin#1358) [iOS] Admin Dashboard - Parental Ratings (jellyfin#1353) [iOS & tvOS] Error Cleanup (jellyfin#1357) update (jellyfin#1356) Fix possible duplicate ids (jellyfin#1354) [tvOS] Media Item Menu - Refresh / Delete Items (jellyfin#1348) ... Signed-off-by: ddrccw <[email protected]>
Summary
Continues the work from #1113 with updates from the feedback provided. Increases padding in a lot of locations and swaps out the
Public Users
list for a grid.Since this view is essentially the same thing between
ConnectToServerView
andUserSignInView
I createdSplitLoginWindowView
in the same vein asSplitFormWindowView
. This works as 2 sections, with titles and content, separated by a divider with a Jellyfin logo at the top.For
ConnectToServerView
, the only real changes made are changes to make theLocalServerButton
better mirror thePublicUserButton
and making the connect button match the sign in button.In my screenshots below, I duplicated by Server/Users to fill out the list more. This is why there are duplicates.
Connect To Server
Before
After
User Sign In
Before
After