Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS] Update ConnectToServerView & UserSignInView #1365

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Dec 17, 2024

Summary

Continues the work from #1113 with updates from the feedback provided. Increases padding in a lot of locations and swaps out the Public Users list for a grid.

Since this view is essentially the same thing between ConnectToServerView and UserSignInView I created SplitLoginWindowView in the same vein as SplitFormWindowView. This works as 2 sections, with titles and content, separated by a divider with a Jellyfin logo at the top.

For ConnectToServerView, the only real changes made are changes to make the LocalServerButton better mirror the PublicUserButton and making the connect button match the sign in button.

In my screenshots below, I duplicated by Server/Users to fill out the list more. This is why there are duplicates.

Connect To Server


Before

Screenshot 2024-12-17 at 12 44 41

After

Screenshot 2024-12-17 at 12 26 26

User Sign In


Before

Screenshot 2024-12-17 at 12 43 15

After

Screenshot 2024-12-17 at 12 27 28

@JPKribs
Copy link
Member Author

JPKribs commented Dec 18, 2024

Here's what this now look like:

Just moved this to the actual toolbar to work better. Here are all of the views that have this:

User Selection

With Background
Simulator Screenshot - Apple TV 4K (3rd generation) - 2024-12-17 at 22 08 24

Without Background
Simulator Screenshot - Apple TV 4K (3rd generation) - 2024-12-17 at 22 08 30


User Login

With example ProgressView()
Simulator Screenshot - Apple TV 4K (3rd generation) - 2024-12-17 at 22 20 22


Server Connection

Simulator Screenshot - Apple TV 4K (3rd generation) - 2024-12-17 at 22 08 48

Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm moving away from the pattern of functions on views that supply the content through () -> any View, at least where the views aren't actually customizable and should be using generics instead.

These views still have some work that can be done like having the server splash screen on the background of UserSignInView as well as some design refinements.

@LePips LePips merged commit 97affd1 into jellyfin:main Dec 19, 2024
4 checks passed
@JPKribs JPKribs deleted the tvOSSignInView branch December 19, 2024 21:34
ddrccw added a commit to ddrccw/Swiftfin that referenced this pull request Jan 26, 2025
* upstream/main: (392 commits)
  [tvOS] Add pin prompt to sign-in screen (jellyfin#1383)
  [iOS] Admin Dashboard - User Access Tags (jellyfin#1377)
  [Meta] 2025 Disclaimer (jellyfin#1381)
  [tvOS] Delete User from User Selection Screen (jellyfin#1359)
  [iOS] Media Item Menu - Identify Media Item (jellyfin#1369)
  [iOS] Admin Dashboard - User Profiles (jellyfin#1328)
  [iOS] Select all Users When Editing (jellyfin#1373)
  [Meta] Automatic String Organization (jellyfin#1372)
  [iOS & tvOS] Unused Localization Cleanup (jellyfin#1362)
  [tvOS] SelectServerView Change to Menu (jellyfin#1363)
  [tvOS] Update ConnectToServerView & UserSignInView (jellyfin#1365)
  Trim Fastlane Options (jellyfin#1367)
  Update Fastlane Runner (jellyfin#1366)
  [iOS & tvOS] Localize Existing Strings (jellyfin#1361)
  [iOS] Admin Dashboard - User Access Schedules (jellyfin#1358)
  [iOS] Admin Dashboard - Parental Ratings (jellyfin#1353)
  [iOS & tvOS] Error Cleanup (jellyfin#1357)
  update (jellyfin#1356)
  Fix possible duplicate ids (jellyfin#1354)
  [tvOS] Media Item Menu - Refresh / Delete Items (jellyfin#1348)
  ...

Signed-off-by: ddrccw <[email protected]>
@JPKribs JPKribs added the enhancement New feature or request label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants