[tvOS] SelectServerView Change to Menu

[JPKribs]

Summary

Changes up some of the padding, coloring, and rounding of the FullScreenMenu. Enable FullScreenMenu as a ViewModifier to allow it to be used as View.fullScreenMenu. Create a modifier to the FullScreenMenu for orientation to allow the view to be either leading or trailing for more dynamic usage.

Clean up the SelectServerView to utilize the new FullScreenMenu and better mirror Apple's default Alert.

Videos

Old:

Old.mp4

New:

New.mp4

Screenshots

SelectServerView Buttons (Old vs New)

SelectServerView Server List (Old vs New)

FullScreenMenu Color Changes (Alert vs Old | Alert vs New)

[LePips]

Why not first investigating Menu? Moving to tvOS 17 as minimum to use Menu for this screen at the very least was a primary motivation.

[JPKribs]

I mostly went this direction since the Menu doesn't work from the Toolbar. I have a branch where I put this into a Menu which I think looks like this:

The only downside I see is the scroll scrolls with everything so we can't pin anything at the top like I did in my FullScreenMenu. Not the end of the world at all but just a note:

If you'd prefer, I can use this instead. This does mean there is no other usage of FullScreenMenu so would we want to delete that or do we think there is some potential usage elsewhere?

[JPKribs]

I've updated this to be the Menu and I removed the 2 views that are no longer used. Actually a big fan of the Menu and it seems to be a lot sturdier on the emulator as well so I think that's the best way to go!

Let me know if you want me undo any of the deletions on this PR in case we need those views in the future.