[iOS & tvOS] Error Cleanup #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drafting real quick. Going to localize everything in those views while I'm touching them. Edit: Okay! All localized! |
LePips
approved these changes
Dec 11, 2024
ddrccw
added a commit
to ddrccw/Swiftfin
that referenced
this pull request
Jan 26, 2025
* upstream/main: (392 commits) [tvOS] Add pin prompt to sign-in screen (jellyfin#1383) [iOS] Admin Dashboard - User Access Tags (jellyfin#1377) [Meta] 2025 Disclaimer (jellyfin#1381) [tvOS] Delete User from User Selection Screen (jellyfin#1359) [iOS] Media Item Menu - Identify Media Item (jellyfin#1369) [iOS] Admin Dashboard - User Profiles (jellyfin#1328) [iOS] Select all Users When Editing (jellyfin#1373) [Meta] Automatic String Organization (jellyfin#1372) [iOS & tvOS] Unused Localization Cleanup (jellyfin#1362) [tvOS] SelectServerView Change to Menu (jellyfin#1363) [tvOS] Update ConnectToServerView & UserSignInView (jellyfin#1365) Trim Fastlane Options (jellyfin#1367) Update Fastlane Runner (jellyfin#1366) [iOS & tvOS] Localize Existing Strings (jellyfin#1361) [iOS] Admin Dashboard - User Access Schedules (jellyfin#1358) [iOS] Admin Dashboard - Parental Ratings (jellyfin#1353) [iOS & tvOS] Error Cleanup (jellyfin#1357) update (jellyfin#1356) Fix possible duplicate ids (jellyfin#1354) [tvOS] Media Item Menu - Refresh / Delete Items (jellyfin#1348) ... Signed-off-by: ddrccw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR finds all instances where
isPresentingErroris used as aState. I'm using this to to find where errors are presented via an alert and I am replacing them with the newerrorMessage(error). In addition to this, I updated a couple typos likeUplicatesvsDuplicates. Finally, I tried toMarkthe classes and break up the variables to try and make everything more readable.The primary goal of this is the errors so if the
MARKs are unwanted I can remove those.Here is an example of why I wanted to get all of these on the same page. Left is current. Right is updated. Should make this easier to maintain as well!
