[iOS] Admin Dashboard - Parental Ratings #1353
Conversation
JPKribs
changed the title
|
Hm, I think that there is something better we can do than just a |
|
Looking at the other media servers, they handle this groupings like 'Teen' or 'Kid' that are more ambiguous but cleaner. On our end, just from the US one looks like:
We could just break this out into like... Anyone, kid=7, otherkid=10, teen=13, somethingteen=14, adult=17? I'm terrible at naming but this could be the cleanest route then we can move the details of this into a Learn More where we say Kid Ratings:
Adult Ratings:
For reference, this is where the localized ratings live: Here's a version of this:
|
|
I had thought about something like that as well: to just show the shared ages of the parental ratings. I think that's the way go since we've both come across it. I think we can make it better with a |
Here is my working version. Let me know what you think! 0 goes to "All Audiences". Anything 100+ I just use the name of the rating. I wanted to use the Dropdown
LearnMore
|
There was a problem hiding this comment.
Learn More without a bulleted list looks great. However, I think the way the ages are presented is odd. The ages are for the maximum age allowed whereas we are presenting them like "this range and up aren't allowed", or could even be misinterpreted as "this range is allowed".
We can simplify that this is the Max parental rating and don't need the + in the strings.
...fin/Views/AdminDashboardView/ServerUserParentalRatingView/ServerUserParentalRatingView.swift
Show resolved
Hide resolved
Here is my latest commit. Made the StateObject change + the String change: |
That's a good change! Only note, without the foregroundStyle, the LearnMore inherits the style from the footer and looks like this:
Opposed to this: Not an issue just so you're aware before we merge if we want to change the section headers to Color.primary instead. |
|
Thanks for pointing that out. I've fixed it on the |
Perfect! I'm a big fan of doing that there since I don't know if we'll need to vary that anywhere else. Thanks for your help and feedback getting this over the finish line! |
* upstream/main: (392 commits) [tvOS] Add pin prompt to sign-in screen (jellyfin#1383) [iOS] Admin Dashboard - User Access Tags (jellyfin#1377) [Meta] 2025 Disclaimer (jellyfin#1381) [tvOS] Delete User from User Selection Screen (jellyfin#1359) [iOS] Media Item Menu - Identify Media Item (jellyfin#1369) [iOS] Admin Dashboard - User Profiles (jellyfin#1328) [iOS] Select all Users When Editing (jellyfin#1373) [Meta] Automatic String Organization (jellyfin#1372) [iOS & tvOS] Unused Localization Cleanup (jellyfin#1362) [tvOS] SelectServerView Change to Menu (jellyfin#1363) [tvOS] Update ConnectToServerView & UserSignInView (jellyfin#1365) Trim Fastlane Options (jellyfin#1367) Update Fastlane Runner (jellyfin#1366) [iOS & tvOS] Localize Existing Strings (jellyfin#1361) [iOS] Admin Dashboard - User Access Schedules (jellyfin#1358) [iOS] Admin Dashboard - Parental Ratings (jellyfin#1353) [iOS & tvOS] Error Cleanup (jellyfin#1357) update (jellyfin#1356) Fix possible duplicate ids (jellyfin#1354) [tvOS] Media Item Menu - Refresh / Delete Items (jellyfin#1348) ... Signed-off-by: ddrccw <[email protected]>
Summary
Allows settings the maximum Parental Rating for a User. Also allows changing how unrated or unrecognized ratings are handled based on Type.
The way this works on Server is ratings have a name and a number associated to them. This way, TV-14 and PG-13 are roughly the same value. This is why they are grouped together like this:
I've done the same thing for us. It's a bit cluttered looking but I'm not sure how else to show this.
Screenshots
Dropdown
Other Options