-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SliverWoltModalSheetPage and WoltModalSheetPage classes to construct modal sheet pages #95
Merged
ulusoyca
merged 6 commits into
main
from
use-different-wolt-modal-sheet-page-class-for-sliver-usage
Nov 14, 2023
Merged
Introduce SliverWoltModalSheetPage and WoltModalSheetPage classes to construct modal sheet pages #95
ulusoyca
merged 6 commits into
main
from
use-different-wolt-modal-sheet-page-class-for-sliver-usage
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TahaTesser
approved these changes
Nov 13, 2023
Comment on lines
47
to
49
Widget? pageTitle, | ||
double? navBarHeight, | ||
Widget? topBarTitle, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Widget? pageTitle, | |
double? navBarHeight, | |
Widget? topBarTitle, | |
super.pageTitle, | |
super.navBarHeight, | |
super.topBarTitle, |
Use super
for these and follow up properties
WoltModalSheetPage({
required this.child,
super.pageTitle,
super.navBarHeight,
super.topBarTitle,
super.heroImage,
super.heroImageHeight,
super.backgroundColor,
super.hasSabGradient,
super.sabGradientColor,
super.enableDrag,
super.forceMaxHeight = false,
super.isTopBarLayerAlwaysVisible,
super.hasTopBarLayer,
super.scrollController,
super.stickyActionBar,
super.leadingNavBarWidget,
super.trailingNavBarWidget,
super.topBar,
}) : super(mainContentSlivers: [SliverToBoxAdapter(child: child)]);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update follow up properties for super
too
Also there some analyzer issues |
Co-authored-by: Taha Tesser <[email protected]>
0f0b8cc
to
895edde
Compare
895edde
to
2aa9103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR marks a significant enhancement to the WoltModalSheet library with the introduction of two new classes,
SliverWoltModalSheetPage
andWoltModalSheetPage
. Alongside these additions, the PR also includes updates to the README file, ensuring necessary documentation and guidance for these new features.This PR also addresses the issue: #72
Introduction of New Classes:
SliverWoltModalSheetPage
: This class is designed for creating complex and dynamic modal sheet pages using Flutter's Sliver widgets. It enables advanced use cases requiring custom scroll behaviors and efficient rendering for large or complex lists.WoltModalSheetPage
: A simpler alternative for modal sheets with straightforward content, this class automatically wraps a single widget in a SliverToBoxAdapter. It's perfect for single-widget content or basic layouts without the need for elaborate scrolling effects.Enhanced README File:
The README has been updated to include detailed sections on the usage of
SliverWoltModalSheetPage
andWoltModalSheetPage
. These sections offer clear instructions, benefits, and example code snippets, providing developers with all the information needed to utilize these classes effectively. Additional emphasis has been placed on the distinction between these two classes, guiding developers on choosing the appropriate class based on their specific requirements.Example Application Update:
The example application has been updated to demonstrate the practical implementation of both classes. This includes showcasing the capabilities of
SliverWoltModalSheetPage
with sliver effects and the straightforward usage ofWoltModalSheetPage
.multiple_slivers.mp4