Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of using factory constructors create abstract WoltModalSheetPage and extend lazy and SingleChild modal sheet pages #71

Closed
ulusoyca opened this issue Oct 9, 2023 · 2 comments
Closed

Instead of using factory constructors create abstract WoltModalSheetPage and extend lazy and SingleChild modal sheet pages #71

ulusoyca opened this issue Oct 9, 2023 · 2 comments

Comments

@ulusoyca
Copy link
Collaborator

ulusoyca commented Oct 9, 2023

It is hard & error prone to maintain factory classes when adding new fields WoltModalSheetPage. Instead we should have abstract definition of WoltModalSheetPage, or have the single child as default WoltModalSheetPage, and then create a LazyList version of WoltModalSheetPage class.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

This issue is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 8, 2023
@ulusoyca
Copy link
Collaborator Author

Merged #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yunusemrebakir @ulusoyca