Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of providing sliverList, add Sliver list in sliver type modal page. #72

Closed
ulusoyca opened this issue Oct 9, 2023 · 6 comments
Closed

Instead of providing sliverList, add Sliver list in sliver type modal page. #72

ulusoyca opened this issue Oct 9, 2023 · 6 comments
Labels
wolt priority

Comments

@ulusoyca
Copy link
Collaborator

ulusoyca commented Oct 9, 2023

Sometimes, in some designs we need SliverToBoxAdapter and SliverList together. Currently it only takes sliverList
@IT-Support-AM
Copy link

Any updates on this? Is it somehow possible?

@ulusoyca
Copy link
Collaborator Author

ulusoyca commented Nov 8, 2023

Hi @IT-Support-AM, I am working on it this week. I will keep you updated.

@ulusoyca ulusoyca mentioned this issue Nov 10, 2023
Merged
@ulusoyca
Copy link
Collaborator Author

@IT-Support-AM The PR is in place: #95

@IT-Support-AM
Copy link

@ulusoyca Thank you!

@ulusoyca
Copy link
Collaborator Author

PR is merged. Closing the issue.

@ulusoyca
Copy link
Collaborator Author

@IT-Support-AM This is released now: https://github.com/woltapp/wolt_modal_sheet#migration-from-01x-to-020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wolt priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ulusoyca @IT-Support-AM