Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bzip2 to common-utils (former https://github.com/microsoft/vscode-dev-containers/pull/1586) #142

Merged
merged 2 commits into from
Sep 8, 2022
Merged

add bzip2 to common-utils (former https://github.com/microsoft/vscode-dev-containers/pull/1586) #142

merged 2 commits into from
Sep 8, 2022

Conversation

lucasfcnunes
Copy link
Contributor

No description provided.

@lucasfcnunes lucasfcnunes requested a review from a team as a code owner September 7, 2022 13:12
@lucasfcnunes lucasfcnunes mentioned this pull request Sep 7, 2022
Closed
samruddhikhandale
samruddhikhandale requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Requested one change, besides that LGTM.

image

bzip2 package will consume approx 196 kB of extra space.

@lucasfcnunes lucasfcnunes mentioned this pull request Sep 8, 2022
Closed
samruddhikhandale
samruddhikhandale approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samruddhikhandale samruddhikhandale merged commit 32578d6 into devcontainers:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasfcnunes @samruddhikhandale