-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for libabseil 20240116, libgrp 1.61, libprotobuf 4.25.2 #372
Conversation
…nda-forge-pinning 2024.02.23.21.25.19
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I haven't debugged yet, but:
|
That's a simple header-inclusion issue - I think abseil got rid of a few transitive imports. For using
Unsurprisingly, this got noticed upstream as well, so we can just backport tensorflow/tensorflow@a733cb1 |
Again, i haven't troubleshot at all:
|
So I redid the backport to double-check, and I basically have the same as you (only that I wouldn't have kept the include of Given that the error is happening in the abseil headers itself, and the definition there calls it "ugly code" and "poor man's C++17 fold expression for C++14", I'm kinda thinking compiler error? Looking more closely at the history of that code, I found that it was introduced recently, and in fact, someone else had already noted that breakage. There's now an issue to track this: abseil/abseil-cpp#1629 PS. That stacktrace is very borked w.r.t. line breaks (and chopping off the |
i don't know enough about C++17 fold expressions, but maybe I can try chatgpt's code:
|
Hmm, i can't recreate the failure in interactive mode.... I get the following failure before I get to it:
|
That lib needs to do |
|
A few things (third party) seem to link to
|
It got renamed to |
@hmaarrfk, I'm having trouble reproducing the failure you got w.r.t. With the following reduced code (from upstream issue)
|
I'm really trying to recreate it.... maybe it was an error in my server...... |
I don't doubt that it's real, as at least one other person ran into the same issue. It seems there's some sort of more complicated interaction happening, but no idea. Worst case you can always restart a full rebuild, or we try a single build on the cirun server |
FYI just restarting my the builds now with linking absl_log_flags. 14k / 22k files compiled. |
Sigh it never gets easier
For note, i probably was trying to build cuda 12.0 but i can't remember. |
The good thing with a abseil is that it's relatively easy to read off the library in which this should be available: |
updated file with actual content |
I'm having trouble applying patches and getting this to run cleanly. I'm going to revert this and work on a branch 0021-Link-to-absl_log_flags-instead-of-absl_flags.patch.txt |
c63fc24
to
22fef6b
Compare
|
So that nvcc-bug was now worked around in abseil, and I've backported it to our build. |
k restarting the build |
Using |
My build locally tests were failing last night. Couldn’t figure out why |
@xhochy I'm still getting an error similar to:
did you do anything to work around that? |
…nda-forge-pinning 2024.03.10.12.43.11
…nda-forge-pinning 2024.03.10.12.43.11
This reverts commit 50904e2.
…nda-forge-pinning 2024.04.03.17.55.34
This PR has been triggered in an effort to update libabseil20240116_libgrpc161_libprotobuf4252.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8032512822, please use this URL for debugging.