Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGL v2.1.0 w/ liburing #36

Merged
merged 9 commits into from
May 29, 2024
Merged

DGL v2.1.0 w/ liburing #36

merged 9 commits into from
May 29, 2024

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Mar 8, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This replaces the earlier bot PR and hence:
closes #35.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus zklaus mentioned this pull request Mar 8, 2024
3 tasks
@zklaus
Copy link
Contributor Author

zklaus commented Mar 8, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/dgl-feedstock/actions/runs/8204457973.

@zklaus zklaus force-pushed the v2.1.0-zklaus branch 2 times, most recently from 8a7d5b5 to 84477e6 Compare March 11, 2024 17:21
@zklaus
Copy link
Contributor Author

zklaus commented Mar 12, 2024

The broken link check is most likely due to conda-forge/admin-requests#958. @conda-forge-admin, please restart ci.

@zklaus
Copy link
Contributor Author

zklaus commented Mar 12, 2024

@conda-forge-admin, please rerender

1 similar comment
@zklaus
Copy link
Contributor Author

zklaus commented Mar 12, 2024

@conda-forge-admin, please rerender

@jakirkham
Copy link
Member

@conda-forge-admin , please restart CI

@zklaus
Copy link
Contributor Author

zklaus commented Mar 14, 2024

Ok, seems everything is working now, except for the Osx builds, which are blocked by conda-forge/tensorflow-feedstock#372 or conda-forge/tensorflow-feedstock#374.

@zklaus
Copy link
Contributor Author

zklaus commented May 24, 2024

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Contributor Author

zklaus commented May 24, 2024

@conda-forge-admin, please rerender

@zklaus
Copy link
Contributor Author

zklaus commented May 24, 2024

@h-vetinari, would you have any hints on what to do about those stdlib2.12 cuda builds?

@h-vetinari
Copy link
Member

So I think what's happening is that - in a CUDA-enabled recipe - you're overriding this big zip, and as you're only overriding it partially (one key out of many), you need to match the length of the other keys in that zip.

I needed to do something similar in arrow to override the compiler version (note, you'd need a third entry for linux because the CUDA 12 migrator adds to the length of that zip).

Perhaps an easier alternative would be to set

os_version:
  linux_64: cos7

in conda-forge.yml though, which should also ensure that you get the newer stdlib

zklaus added a commit to zklaus/dgl-feedstock that referenced this pull request May 27, 2024
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@zklaus
Copy link
Contributor Author

zklaus commented May 27, 2024

@conda-forge-admin, please rerender

zklaus added a commit to zklaus/dgl-feedstock that referenced this pull request May 28, 2024
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Contributor Author

zklaus commented May 28, 2024

Seems this is finally ready, @conda-forge/dgl 🎉 However, I suggest to first merge #38, then rebase this on top of the new main and only merge after that.

@zklaus zklaus marked this pull request as ready for review May 29, 2024 14:15
@hmacdope
Copy link
Contributor

Thanks so much for fixing conflicts @zklaus

Copy link
Contributor

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmacdope hmacdope merged commit 5a38679 into conda-forge:main May 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants