-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DGL v2.1.0 w/ liburing #36
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/dgl-feedstock/actions/runs/8204457973. |
8a7d5b5
to
84477e6
Compare
The broken link check is most likely due to conda-forge/admin-requests#958. @conda-forge-admin, please restart ci. |
@conda-forge-admin, please rerender |
1 similar comment
@conda-forge-admin, please rerender |
@conda-forge-admin , please restart CI |
Ok, seems everything is working now, except for the Osx builds, which are blocked by conda-forge/tensorflow-feedstock#372 or conda-forge/tensorflow-feedstock#374. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
@h-vetinari, would you have any hints on what to do about those stdlib2.12 cuda builds? |
So I think what's happening is that - in a CUDA-enabled recipe - you're overriding this big zip, and as you're only overriding it partially (one key out of many), you need to match the length of the other keys in that zip. I needed to do something similar in arrow to override the compiler version (note, you'd need a third entry for linux because the CUDA 12 migrator adds to the length of that zip). Perhaps an easier alternative would be to set
in |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Seems this is finally ready, @conda-forge/dgl 🎉 However, I suggest to first merge #38, then rebase this on top of the new main and only merge after that. |
…nda-forge-pinning 2024.05.28.17.08.08
Thanks so much for fixing conflicts @zklaus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
Bumped the build number (if the version is unchanged)0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This replaces the earlier bot PR and hence:
closes #35.