-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for libprotobuf 4.25.1 #371
Rebuild for libprotobuf 4.25.1 #371
Conversation
…nda-forge-pinning 2024.01.31.14.25.19
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I've started to attempt to build linux (all variants). @xhochy are you able to try to build osx? |
sorry i jumped on this too soon. this needs bazel which needs |
|
It seems that the discussion in conda-forge/gazebo-feedstock#201 and the suggested fix: protocolbuffers/protobuf@bb4718c is helping |
Even with "fixing" libprotobuf, we still fail with the build with:
|
Key part here being:
This is vendored by tensorflow here, coming from https://github.com/google/riegeli originally. I see that tensorflow applies a patch to riegeli (and by building through bazel, we should be doing the same), but it doesn't look particularly related. |
Thanks!! I need to presently (for the next few hours) focus on other things. Glad others (like yourself!!!) are able to help while before I completely delete the logs. Even having hidden tmux panes makes me stressed….. |
Do you want me to hold off with merging libprotobuf v25.2 until we've fixed tensorflow (in case we need more patches to v25.1)? Otherwise I'm planning to go ahead and trigger a bigger migration (abseil/grpc/protobuf). |
Go for it. |
There's now a PR for a newer protobuf version: #372; if we're lucky the error has been resolved? |
This PR has been triggered in an effort to update libprotobuf4251.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7730760900, please use this URL for debugging.