Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate methods of WoltModalSheet #208

Merged

Conversation

ulusoyca
Copy link
Collaborator

Description

We introduced static in-modal navigation methods to WoltModalSheet but not released (#188). After receiving feedback #202 (comment) I agree that there are two ways of using the same method. This PR utilizes only WoltModalSheet.of(context).method type of methods for in-modal navigation.

image

Related Issues

Fixes #202 (comment)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@ulusoyca ulusoyca requested a review from AcarFurkan May 20, 2024 20:48
@ulusoyca ulusoyca mentioned this pull request May 20, 2024
@ulusoyca ulusoyca enabled auto-merge May 20, 2024 20:49
@AcarFurkan AcarFurkan disabled auto-merge May 20, 2024 20:53
@ulusoyca ulusoyca force-pushed the remove-unnecessary-duplicate-methods-of-wolt-modal-sheet branch from 0ba7050 to 2bd1f60 Compare May 20, 2024 20:53
@ulusoyca ulusoyca enabled auto-merge May 20, 2024 20:54
@ulusoyca ulusoyca merged commit 632b720 into main May 20, 2024
3 of 4 checks passed
@ulusoyca ulusoyca deleted the remove-unnecessary-duplicate-methods-of-wolt-modal-sheet branch May 20, 2024 20:55
Copy link

Visit the preview URL for this PR (updated for commit 2bd1f60):

(expires Mon, 27 May 2024 20:56:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 906758393beb0353b979d020649d6a1efc40fb5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add getter for atRoot
2 participants