-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enhanced Navigation Methods to WoltModalSheet #188
Conversation
Visit the preview URL for this PR (updated for commit 0f8c7b8):
(expires Fri, 10 May 2024 06:52:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 906758393beb0353b979d020649d6a1efc40fb5b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR Overall!
I'd prefer the main lib changes and example changes are split separate PRs in future. This makes it easy to read the library code and test the changes. We might require tests in the future.
Add imperative navigation methods Fix navigation issues
This reverts commit 26cdf5e.
Co-authored-by: Taha Tesser <[email protected]>
Co-authored-by: Taha Tesser <[email protected]>
b3bdd33
to
da2ee76
Compare
Please rebase after merging #192 |
@ulusoyca
I'll update the tests in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank y'all so much. This is package is a dream! When do you think this'll be on pub? |
Description
This pull request introduces a comprehensive suite of navigation methods to the
WoltModalSheet
widget. These methods are designed to facilitate more intuitive and adaptable multi-page in-modal navigation scenarios.Note that this is not a breaking page. Users can still use
pageIndexNotifier
for navigation.Dynamic Stack Management
add_single_page.mov
add_multiple_pages.mov
push_multi_page.mov
replace_current_page.mov
replace_previous_page.mov
replace_all_pages.mov
pop_page.mov
Key Navigation Methods Added:
addPages, addPage: Append new pages to the navigation stack.
replaceCurrentPage, replaceAllPages, replacePage: Replace existing pages in the stack.
removePage, removeUntil: Remove pages from the stack based on specific criteria.
pushPages, pushPage: Push new pages onto the stack and display them immediately.
popPage: Pop the top page from the navigation stack.
showNext, showPrevious: Navigate forward or backward within the stack.
showAtIndex, showPageWithId: Navigate directly to a specific page by index or ID.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process.
///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?