Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow scroll effect visibility when top bar is always visible #104

Merged

Conversation

ulusoyca
Copy link
Collaborator

Description

When the top bar is set to always visible, the overflow scroll effect from the leading side (top part) will not be visible since the custom scroll view is placed and starts behind the top bar.

This PR adds explicit padding to the custom scroll view when isTopBarLayerAlwaysVisible is set to true.

This is how all the pages look after the fix:

fix_top_bar_glow.mp4

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [-] Yes, this is a breaking change.
  • [-] No, this is not a breaking change.

@ulusoyca ulusoyca enabled auto-merge December 12, 2023 12:07
@ulusoyca ulusoyca merged commit a2f86e6 into main Dec 12, 2023
@ulusoyca ulusoyca deleted the fix-overflow-scroll-effect-hidden-when-top-bar-is-always-visible branch December 12, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants