List not scrolling properly

[mmotkim]

Hi, loving your package so far because of the easy routes, I've just come across a problem here:

Bug report

When trying to display a list in a WoltModalSheetPage, either using Single child and ListView.builder or Sliver list and SliverList.builder:

on Android using ListView.builder: double GlowingOverscrollIndicator when overscrolling on the bottom
on iOS using ListView.builder: The last item of the list keeps being hidden by the list height constraint. It's still there, but when I scroll to the bottom it doesn't show up unless I overscroll. It's like the itemCount misses an item.
It could be worked around by adding bottom padding to the whole list but then empty space would show up on android

on Android using SliverList: The GlowingOverscrollIndicator gets partially hidden by the TopBar
on iOS using SliverList: The scrolling animation is janky, and there's no Overscroll physics and Bouncing physics

Android using ListView.builder:

Steps to reproduce

Using ListView.builder on WoltModalSheetPage.withSingleChild() and SliverList.builder on WoltModalSheetPage.withCustomSliverList with TopBar

---

Additional context

Flutter 3.13.9
Dart 3.1.5

Tell me if you require additional context or code snippets

[ulusoyca]

Hi @mmotkim Thanks for opening the issue.

The GlowingOverscrollIndicator gets partially hidden by the TopBar on iOS using SliverList.

This is a bug because the list in the main content is behind the top bar. It is fixed in this [PR] (#104) and will be released in next release.

There's no Overscroll physics and Bouncing physics

This was a bad design decision we took earlier. This PR introduces custom scroll physics and scroll behavior for the main content. The junkiness may happen when you dont use a lazy list.

Unfortunately I am not able to reproduce the double glowing effect in coffee maker example. Here you can see the behavior:

offer_recommondation_scroll.mp4

Can you please check the implementation here.

You should not be able to use ListView.builder in pages without a sliver factory constructor, unless you add shrinkWrap: true and physics to NeverScrollablePhysics. Please check this example of how to use it here.

[ulusoyca]

@mmotkim This is merged and released with 0.2.0 and please let us know if this persists.