Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom scroll behavior, allow scroll physics customization, fix double scroll effects and double scroll bars #103

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

ulusoyca
Copy link
Collaborator

Description

Initially, we had a bad practice of hardcoding scroll behaviors and scroll physics in the package. This information has been an internal detail in the main content implementation, and causing confusion to the users.

This PR addresses the following:

  • Removes custom DragScrollBehavior from all examples and the main content component in the scroll list.
  • Demonstrates how to add a custom scroll behavior to MaterialApp in all of the examples.
  • Adds a scrollPhysics field to the ThemeData to enable customizing of the physics in the main content custom scroll view. Adds an example to the ReadMe file for this field.
  • Adds DeviceInfo package to the playground example to be able to test different overscroll effects on Android.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [-] My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Collaborator

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

There are a bunch of changes in just one PR including platform related. Preferably splitting these unrelated changes would make easier to test and review

@ulusoyca ulusoyca enabled auto-merge December 12, 2023 12:06
@ulusoyca ulusoyca dismissed TahaTesser’s stale review December 12, 2023 13:01

Changes are in place, Taha is on vacation.

@ulusoyca ulusoyca merged commit 438c80e into main Dec 12, 2023
@ulusoyca ulusoyca deleted the make-scroll-behavior-configurable branch December 12, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants