-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for missing download path #776
Conversation
d0eb2df
to
1ec3051
Compare
@@ -274,6 +274,7 @@ function saveTorrentFileAs (torrentSummary) { | |||
] | |||
} | |||
electron.remote.dialog.showSaveDialog(electron.remote.getCurrentWindow(), opts, function (savePath) { | |||
if (!savePath) return // They clicked Cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
This is good. One concern though: this only shows the user a message when the download folder is gone, but it doesn't prevent the active torrents from being added to the torrent engine, right? That means that We should probably wait for the check to confirm the directory exists before adding to the torrent engine. But, come to think of it, there's a bigger issue. The default download path in Preferences is not necessarily the same as the torrents. The preference could have been changed to an external drive after several torrents were already started in ~/Downloads. In that case, the torrents that live in ~/Downloads should show up in the list and be usable by the user. What do you think about changing this PR As for the warning about the default download path being missing, I think that can stay. But I don't think it shouldn't prevent rendering of the entire torrent list when it's missing. What about just showing the warning at the top of the list? |
Ya, I just wanted to do the easy part first. I can a per-torrent check similar to the one Transmission has. |
c5b207a
to
bef7f90
Compare
@feross fixed. New error message |
26cdac8
to
85f6b6e
Compare
85f6b6e
to
0809e20
Compare
LGTM -- we can work on improving the design of this and honing the copy in a future PR. |
Released in WebTorrent Desktop v0.11! |
Also handle the case where the user cancels out of Save Torrent File As
Fixes #646.