Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Path Warnings Needed #646

Closed
MarkIvanowich opened this issue Jun 16, 2016 · 3 comments
Closed

File Path Warnings Needed #646

MarkIvanowich opened this issue Jun 16, 2016 · 3 comments
Labels

Comments

@MarkIvanowich
Copy link

What version of WebTorrent Desktop? Version 0.7.2 (0.94.3)

What operating system and version? elementary OS 0.3.2 Freya (64-bit) Built on Ubuntu 14.04

What did you do? Start WebTorrent without mounted drive, where Download Path resides

What did you expect to happen? Error, Download Path does not exist, confirmation to create path or choose alternative.

What actually happened? Folder created in /media/user/, where files were downloaded off away from desired location

Details
Obviously I am saving all my torrents to a separate drive on my PC, where the drive has to be mounted before using. Silly me, I start WebTorrent before this happens. WebTorrent happily chugs along, downloads the files, returns no warnings. I realize after the download that my drive is not mounted, and the downloaded files are in /media/mark/External_Drive1/Torrent_Downloads/ when External_Drive is not mounted. (Please note that the incremented number may be from mounting the drive after Ubuntu sees the original path as not empty.)

I safely moved the files to the drive, however WebTorrent still thinks the torrents reside in _Drive1. Closing the application, modifying the .config file, and reopening did not resolve the issue. I had to edit the config file, kill WebTorrent process, and then reopen for changes to make effect.

Possible Solutions
Upon opening the application, the download path should be tested to see if it exists. If it does not exist, a warning should appear to remap, or create the directory. Verbosely, the warning should also detect if the /media path is being used, to suggest remounting & retrying.

Additionally, right clicking each torrent in the list should provide options to change the Download Path of each torrent, moving the files. This could save someone from having files dumped where they don't want, and modifying the .config as I did.

@dcposch
Copy link
Contributor

dcposch commented Jun 23, 2016

Error, Download Path does not exist, confirmation to create path or choose alternative.

Sounds good. I'll add that check

@dcposch dcposch self-assigned this Jun 23, 2016
@feross
Copy link
Member

feross commented Jul 27, 2016

I believe that Transmission checks for this condition and warns the user. We should see what that UX looks like and ensure that we do just as good of a job, if not better.

@feross feross added the bug label Jul 27, 2016
dcposch added a commit that referenced this issue Aug 13, 2016
dcposch added a commit that referenced this issue Aug 13, 2016
@feross
Copy link
Member

feross commented Aug 14, 2016

Fixed by #776!

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants