Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpringBone] reconstruct 時の center の index の offset 足し忘れを修正 #2614

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Mar 17, 2025

fixed #2611

#2609 のバグだった

ついでに unregister + register を一関数で一度にできるようにして、
あわせて順番が変わらないようにした。

@ousttrue ousttrue changed the title Fix/springbone reconstruct colliders [SpringBone] reconstruct 時の center の index の offset 足し忘れを修正 Mar 17, 2025
@ousttrue ousttrue requested a review from suzuryg March 17, 2025 07:32
@@ -300,7 +303,9 @@ private struct InitCurrentTailsJob : IJobParallelFor
public void Execute(int springIndex)
{
var spring = Springs[springIndex];
var center = spring.centerTransformIndex >= 0 ? Transforms[spring.centerTransformIndex] : (BlittableTransform?)null;
var center = spring.centerTransformIndex >= 0
? Transforms[spring.transformIndexOffset + spring.centerTransformIndex]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆 spring.transformIndexOffset の足し忘れ

Copy link

@suzuryg suzuryg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ousttrue ousttrue merged commit d3c408a into vrm-c:master Mar 18, 2025
2 of 3 checks passed
@ousttrue ousttrue deleted the fix/springbone_reconstruct_colliders branch March 18, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SpringBone] collider の増減をして reconstruct すると index がずれて跳ねる
2 participants