-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test suite to stabilize ssr frameworks #2740
Conversation
So the code itself is looking okay, but there are now failing tests |
:-)
I'm good but thanks. I CC'd framework authors so that they are aware of the test suite; would be nice for the test suite to grow. Thanks for the review :-). |
e3b8dac
to
57d94e3
Compare
Looks like the tests are still failing in windows and increasing the timeout doesn't help here. @nihalgonsalves created an issue for the issues with the test suite #3106 |
Thanks ❤️ I was actually wondering about this. And thanks for the pointer to Nihal's GH issue. @nihalgonsalves The errors are |
Still getting timeouts and EDIT: tried again - still no luck. |
tests vitejs#2390 and vitejs#1875 amongst others
This reverts commit f08f81c.
Still no luck on windows. |
Closing this in favor of https://github.com/vitejs/vite-ecosystem-ci |
Tests #2390 #1875 amongst others.
The plan here is to have a test suite that stabilizes the foundation on which Vite SSR frameworks are build on.
One possible downside of this PR is that it can be seen as redundant to
playgroud/ssr-vue
/playground-ssr-react
. But, IMO, the many subtle differences between directly using the Vite API and using a SSR framework which uses the Vite API justifies this PR.Letting know folks who build Vite SSR frameworks @egoist @frandiox @galvez @dominikg @GrygrFlzr @Rich-Harris
The tests fail because #2390 is not merged yet. They will go green once 2390 is merged.