-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support globbing from dependencies #2519
Conversation
8d459e3
to
f7cd2ba
Compare
It's high prio for |
This looks good to me, but I think @yyx990803 explained in an issue why globbing from dependencies was not a good idea (but I can not find it). We'll need to wait for his input about this one. |
There was a previous request for adding support for globbing from dependencies at #1875 which got fixed by Evan You. So I'm assuming this PR would get accepted as well. |
@matias-capeletto Maybe we should label this "p3-downstream-blocker" since it's blocking vite-plugin-ssr. |
@brillout could we add a test for this feature? |
@matias-capeletto Yes! That would actually be great to solidify that use case. I'll make a stab at it (I'm bit woried about how I can use a non-symlinked dependency with the current test architecture, but I'll dig into this). Sorry for the late reply, I was heads down implementing Client-side Routing for vite-plugin-ssr. |
@patak-js I'm almost done with the test. I expect the test to get some back-and-forth with the reviewers so I'm a bit worried that it may delay the merging of this PR. If it's ok with you I will open a second PR for the test so that this PR can get merged quicklier. Please let me know if you object. |
I am fine with that, but this counts as a new feature so we need @yyx990803 approval to merge it. |
I just changed the commit prefix from |
Done: #2740. |
I hit this too building the Solid Starter. For now patching it but look forward to a solution being merged. This seems pretty essential. |
Fixes #2390
The condition
source.includes('import.meta.glob')
won't catch source code likeimport.meta['glob']
or new lines betweenmeta
andglob
, but the subsequenttransform()
code won't either anyways.The advantage of
source.includes('import.meta.glob')
is that we skipes-module-lexer
parsing.