Nuke EmojiEditTextInterface and allow any kind of EditText to be passed. #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
force-pushed
the
nuke-EmojiEditTextInterface
branch
2 times, most recently
from
40ec068 to
cfca25c
Compare
vanniktech
force-pushed
the
nuke-EmojiEditTextInterface
branch
from
cfca25c to
f2ce57e
Compare
|
Hi it is great! i will use it. It is possible to update the maven repository, or are you using other repository? Thanks! |
|
Use the SNAPSHOT version for now please. |
|
ok, thanks! |
|
Why didn't you keep you both implementations? Last SNAPSHOT breaks my custom AppCompatAutoCompleteTextView implementing EmojiEditTextInterface. |
|
It's not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311 & #312