Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use EditText for builder popup instead of EmojiEditText #312

Closed
wants to merge 1 commit into from

Conversation

sebest06
Copy link

Hi, this is the change that I suggest
Thank

@vanniktech
Copy link
Owner

A change for what? What's your motivation and what is this trying to solve?

@sebest06
Copy link
Author

Hi how are you?

For example you have an application with support for "google-compat" to show the emoticons correctly, but the only way to enter them is through the android keyboard. The emoticons look different on the keyboard than what will be displayed.

Here I can integrate your library with the application, if the object (Edit) that I use in your library (to the build method) could be a TextEdit I can integrate your library without problems, my object is not a TextEdit, because it is compatible with google -compat, but inherit from a TextEdit.

In the current version I should implement the EmojiEditText interface, in my Edit type object, and overload some functions, to do something I'm already doing.

Even with the modification that I propose, you could still pass an EmojiEditText to the build method and the library would continue behaving as it does now.

If you look at the code I sent you, I just modify the type, but the rest of the example code is the same.

In this way you could have unlinked the keyboard of the object that receives the emoticon. Which makes it simpler to integrate in different scenarios.

I think it's a change that adds flexibility and does not take anything away. No matter what type of object you use to enter information you can always receive data from your emoticon keyboard.

@vanniktech
Copy link
Owner

Ah okay. I think I got it. This will require probably some changes to our EditText too. I'll have a deeper look hopefully next week.

I think what needs to be done is inlining the backspace / input method. As well as removing the interface.

@premacck
Copy link

Hey any updates on this PR?

@vanniktech
Copy link
Owner

Haven't had time to have a deeper look at this.

@sebest06
Copy link
Author

Ok i know that. I hope we can do that the next year... Happy xmas.

@sebest06
Copy link
Author

sebest06 commented Jan 7, 2019

Hello Vanniktech, how are you? i know that you are busy, but i want to say somethings

I integreted your library in two big projects.
One of these is not happy with the implementation i do not know why...

The other one was more happy, and he asked me a few things of the implementation.

https://github.com/kriztan/Pix-Art-Messenger/pull/288

This is the pull request for if you want to read.

I said that the library is yours and what would this tell you.

Could you take a look when you have time?

Thanks!

@vanniktech
Copy link
Owner

Still on my list. Maybe this week is the week.

@vanniktech
Copy link
Owner

Finally got to this in #324 sorry it took a while.

@vanniktech vanniktech closed this Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants