Feat/upgrade deps and macos build #215
Conversation
|
Thanks a lot Clémence for your very interesting contribution. I will do a review |
|
|
||
| ## Prerequisites | ||
|
|
||
| Be warning to use the right Java version (latest LTS, v17): |
There was a problem hiding this comment.
Java 17 is the baseline of Spring Boot 3: https://spring.io/blog/2022/11/24/spring-boot-3-0-goes-ga
We have to upgrade. But for now I think we could support Java 11 and 17
There was a problem hiding this comment.
I didn't tested the build with both versions. I think it'll add unnecessary complexity to the code. It is really required to support a version which is not the latest LTS?
There was a problem hiding this comment.
Some Java developers are using this sample in their compagny where Java 17 may be not still available in live environment. It's quite commun in big non-IT organization. Thus keeping Java 11 compatibility could be comforting.
README.md
Outdated
| so don't be scared of initial Spring Cloud Gateway timeouts. You can track services availability using Eureka dashboard | ||
| available by default at http://localhost:8761. | ||
| In order to start entire infrastructure using Docker, you have to build images by executing `./mvnw clean spring-boot:build-image` | ||
| from a project root. Once images are ready, you can start them with a single command `docker-compose up`. Containers startup order is coordinated with [`dockerize` script](https://github.com/jwilder/dockerize). |
There was a problem hiding this comment.
I'll update the README accordingly.
|
|
||
| ## Third-parties | ||
|
|
||
| sql-server: |
There was a problem hiding this comment.
Previous version of the Spring Petclinic started by Docker Compose was using a HSQL database and not a MySQL database.
From your git branch, I've tested the docker-compose file with the docker-compose up command.
The whole application didn't start. And I've got this error:
vets-service | 2022-11-29 07:13:50.781 ERROR [vets-service,,] 1 --- [ main] com.zaxxer.hikari.pool.HikariPool : HikariPool-1 - Exception during pool initialization.
vets-service |
vets-service | com.mysql.cj.jdbc.exceptions.CommunicationsException: Communications link failure
vets-service |
vets-service | The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.
vets-service | at com.mysql.cj.jdbc.exceptions.SQLError.createCommunicationsException(SQLError.java:174)
Does that mean anything to you?
|
Clémence MacOS build on ARM architecture has been completed in the #242 |
Hello,
Additions of my proposal:
Regards,