Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dockerize #219

Closed
arey opened this issue Dec 23, 2022 · 3 comments
Closed

Remove dockerize #219

arey opened this issue Dec 23, 2022 · 3 comments
Assignees
@arey
Labels
enhancement

Comments

@arey
Copy link
Member

arey commented Dec 23, 2022

This enhancement has been discussed in the PR #215
The docker-compose.yml could use the service_started and/or the service_healthy condition.
Like in k8s, the Spring Boot application may have started but is not ready to accept HTTP request.
According to the compose spec, the service_healthy looks like better: https://github.com/compose-spec/compose-spec/blob/master/spec.md#healthcheck It requires that we implement healthcheck.
I found this sample: https://github.com/wpcfan/spring-boot-tut/blob/master/docker/docker-compose.yml
@arey arey mentioned this issue Mar 29, 2023
Closed
@alexandre-touret
Copy link

Hi
Dont you think, it could also be an opportunity to use the springboot docker plugin instead of the Spotify one?

e.g.:

./mvnw spring-boot:build-image

@arey
Copy link
Member Author

arey commented Jul 7, 2023

Yes. Once we removed dockerize we could use the Docker build image support from Spring Boot

@arey arey self-assigned this Dec 23, 2023
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Dec 24, 2023
@arey
spring-petclinic#219 Upgrade to docker-compose v3
94b7a15
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Dec 24, 2023
@arey
spring-petclinic#219 Remove dockerize from the Dockerfile and add som…
e4915e6 
…e healthcheck and depends_on to the docker-compose.yml
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Dec 24, 2023
@arey
spring-petclinic#219 Complete Dockerize removal
c064115
@arey arey mentioned this issue Dec 24, 2023
Merged
@arey
Copy link
Member Author

arey commented Dec 24, 2023

@alexandre-touret We're on our way. See #247

arey added a commit that referenced this issue Dec 27, 2023
@arey
Remove dockerize in favor of docker-compose features (#247)
159be8f 
* Use Github Actions for CI

* #219 Upgrade to docker-compose v3

* #219 Remove dockerize from the Dockerfile and add some healthcheck and depends_on to the docker-compose.yml

* #219 Complete Dockerize removal
@arey arey closed this as completed Dec 27, 2023
DavidMolta18 pushed a commit to Distribuidos2024/spring-petclinic-microservices that referenced this issue Nov 14, 2024
@arey
Remove dockerize in favor of docker-compose features (spring-petclini…
0c4ee53 
…c#247)

* Use Github Actions for CI

* spring-petclinic#219 Upgrade to docker-compose v3

* spring-petclinic#219 Remove dockerize from the Dockerfile and add some healthcheck and depends_on to the docker-compose.yml

* spring-petclinic#219 Complete Dockerize removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arey arey

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arey @alexandre-touret