Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong string resource generation when using resourceOverlayDirectory with strings.xml #573

Closed
j-era opened this issue Jan 30, 2015 · 3 comments
Closed

Wrong string resource generation when using resourceOverlayDirectory with strings.xml #573

j-era opened this issue Jan 30, 2015 · 3 comments

Comments

@j-era
Copy link

j-era commented Jan 30, 2015

Encountered some strange behaviour with the maven-android-plugin v4.1.0 and string resources generation.
We have defined a resourceOverlayDirectory to override some resources in the applications original 'res' folder. The resourceOverlayDirectory contains a strings.xml file in the values directory. When we've build our apk with maven, the generated string resources file seems to point to the wrong string values, because wrong string values are placed on the views.
Is there something known what could cause this issue?
@j-era j-era mentioned this issue Jan 30, 2015
Closed
@Shusshu
Copy link
Member

Shusshu commented Feb 1, 2015

Maybe @xcolwell can say something about it even though he hasn't worked on AMP 4.x

Maybe related: #417

@j3nsm4n could you look deeper into the code and see if any adjustments needs to be made?

@xcolwell
Copy link

xcolwell commented Feb 2, 2015

@Shusshu I suggest trying the latest 3.x version if possible and seeing if the unwanted behavior happens there. I believe 4.x introduced a different behavior than 3.x with resource overlays.

jacobmattsson added a commit to jacobmattsson/maven-android-plugin that referenced this issue May 24, 2016
@jacobmattsson
Fixed issues simpligility#417 and simpligility#573, where resource ov…
0a6a661 
…erlays dirs were not properly configured
@jacobmattsson jacobmattsson mentioned this issue May 24, 2016
Merged
mosabua pushed a commit that referenced this issue May 25, 2016
@jacobmattsson
Fixed issues #417 and #573, where resource overlays dirs were not pro…
42dc39f 
…perly configured
@mosabua
Copy link
Member

mosabua commented May 25, 2016

Fixed with linked PR

@mosabua mosabua closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mosabua @xcolwell @Shusshu @j-era