Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourceOverlayDirectories broken in >= 2.8.2 #417

Closed
xcolwell opened this issue Jul 29, 2014 · 9 comments · Fixed by #728
Closed

resourceOverlayDirectories broken in >= 2.8.2 #417

xcolwell opened this issue Jul 29, 2014 · 9 comments · Fixed by #728

Comments

@xcolwell
Copy link

I have an APK that illustrates how resources get mangled in 3.8.2 and on when using resourceOverlayDirectories. The issues is not present in 3.8.1 .

@william-ferguson-au
Copy link
Contributor

Great. Do you have a pull request to fix it?

@mosabua
Copy link
Member

mosabua commented Jul 29, 2014

Also... what about the latest release 3.9.0-rc.3 ... you need to verify it works or is broken with it as this is what we are working on.

@xcolwell
Copy link
Author

@william-ferguson-au I can submit a pull request against the latest (3.9.0-rc3). I've tested 3.8.2 and 3.9.0-rc3. The latter seems to outright ignore resourceOverlayDirectories, whereas the former corrupts the APK.

I haven't submitted to this project before. How do you structure tests?

@mosabua
Copy link
Member

mosabua commented Jul 29, 2014

We are currently revamping a bunch of test stuff.. for now just submit the fix.

@xcolwell
Copy link
Author

@mosabua ok. I'll get put one together this week.

@mosabua
Copy link
Member

mosabua commented Jul 29, 2014

Great... looking forward to it ;-)

@Shusshu
Copy link
Member

Shusshu commented Nov 21, 2014

@xcolwell any luck on it?

btw what is this used for? is it something we can use like the gradle flavors?

@xcolwell
Copy link
Author

@Shusshu

That option is like Gradle flavors - the build swaps resources at compile time, e.g. dev, prod can have different included resources.

Unfortunately I am no longer working on this. I started a new project and started using Gradle. Too bad because Maven for Android is strangely more complete than Gradle, but Gradle seems like the long term right choice.

@mosabua
Copy link
Member

mosabua commented Jan 8, 2015

If you decide to get back to using Maven after some Gradle experience.. we still take pull requests ;-)

@mosabua mosabua closed this as completed Jan 8, 2015
jacobmattsson added a commit to jacobmattsson/maven-android-plugin that referenced this issue May 24, 2016
…erlays dirs were not properly configured
mosabua pushed a commit that referenced this issue May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants