-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resourceOverlayDirectories broken in >= 2.8.2 #417
Comments
Great. Do you have a pull request to fix it? |
Also... what about the latest release 3.9.0-rc.3 ... you need to verify it works or is broken with it as this is what we are working on. |
@william-ferguson-au I can submit a pull request against the latest (3.9.0-rc3). I've tested 3.8.2 and 3.9.0-rc3. The latter seems to outright ignore resourceOverlayDirectories, whereas the former corrupts the APK. I haven't submitted to this project before. How do you structure tests? |
We are currently revamping a bunch of test stuff.. for now just submit the fix. |
@mosabua ok. I'll get put one together this week. |
Great... looking forward to it ;-) |
@xcolwell any luck on it? btw what is this used for? is it something we can use like the gradle flavors? |
That option is like Gradle flavors - the build swaps resources at compile time, e.g. dev, prod can have different included resources. Unfortunately I am no longer working on this. I started a new project and started using Gradle. Too bad because Maven for Android is strangely more complete than Gradle, but Gradle seems like the long term right choice. |
If you decide to get back to using Maven after some Gradle experience.. we still take pull requests ;-) |
…erlays dirs were not properly configured
I have an APK that illustrates how resources get mangled in 3.8.2 and on when using resourceOverlayDirectories. The issues is not present in 3.8.1 .
The text was updated successfully, but these errors were encountered: