Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#452] Remove pul-assets gem #514

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[#452] Remove pul-assets gem #514

wants to merge 2 commits into from

Conversation

vh8154
Copy link
Contributor

@vh8154 vh8154 commented Feb 3, 2025

Closes #452

@christinach christinach force-pushed the 452-remove-pul-assets branch from 168847b to e95d53d Compare February 6, 2025 15:00
@christinach @vh8154
[#452] Include data-tables gem
35c9e9c 
Include normalize-text gem
Both of them were required in pul_assets
Remove overrides related to pul_assets
Copy library_full_logo.svg in images

Co-authored-by: Vivian Ha <[email protected]>
@christinach christinach force-pushed the 452-remove-pul-assets branch from e95d53d to 35c9e9c Compare February 6, 2025 15:45
@vh8154
Copy link
Contributor Author

vh8154 commented Feb 10, 2025 •
edited
Loading

Issues after removing pul-assets:

  • Skip to main content present at top of website
  • Missing topic and region blue sections
  • “Access to these data files is restricted to currently enrolled/employed members of Princeton University” alert is missing the yellow background
  • Spacing issues: between picture and data catalog
  • Picture is now zoomed in
  • All fields drop down and search is slightly different in styling
  • “Bookmarks” now has the blue link color
  • Quick links text is now bigger
  • Quick links now are in a bulleted list
  • The middle section of the footer is slightly moved
  • After logging in, we can see the navigation bar is poorly formatted
  • In addition, this moves the data catalog section to the right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pul-assets dependency
2 participants
@vh8154 @christinach