Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pul-assets dependency #452

Open
1 of 4 tasks
sandbergja opened this issue Aug 8, 2024 · 2 comments · May be fixed by #514
Open
1 of 4 tasks

Remove pul-assets dependency #452

sandbergja opened this issue Aug 8, 2024 · 2 comments · May be fixed by #514
Assignees
@vh8154
Labels
maintenance
Milestone
Rails Application...

Comments

@sandbergja
Copy link
Member

sandbergja commented Aug 8, 2024 •
edited
Loading

What maintenance needs to be done?

Remove pul-assets dependency

Level of urgency

  • High
  • Moderate
  • Low

Why is this maintenance needed?

This is the only non-deprecated application that uses PUL Assets. We already use Lux in this application, which has more up-to-date branding, and is more widely supported.

Acceptance criteria

  • We no longer use the pul-assets gem
@kevinreiss kevinreiss added this to the Rails Application Sprint milestone Aug 13, 2024
@kevinreiss
Copy link
Member

Noting that DSS does not actually use LUX at the moment. The header/footer is provided by this gem if I follow the code.

@christinach
Copy link
Member

Noting that DSS does not actually use LUX at the moment. The header/footer is provided by this gem if I follow the code.

DSS is using Lux in both header and footer see commit a149755fd

@christinach christinach assigned christinach and vh8154 and unassigned christinach Jan 27, 2025
@christinach christinach moved this from Todo to In Progress in DACS - student software dev board Jan 27, 2025
vh8154 added a commit that referenced this issue Jan 28, 2025
@vh8154
[#452] Remove pul-assets gem
2c04d6f
@vh8154 vh8154 linked a pull request Feb 3, 2025 that will close this issue
Draft
christinach added a commit that referenced this issue Feb 6, 2025
@christinach @vh8154
[#452] Include data-tables gem
35c9e9c 
Include normalize-text gem
Both of them were required in pul_assets
Remove overrides related to pul_assets
Copy library_full_logo.svg in images

Co-authored-by: Vivian Ha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vh8154 vh8154

Labels
maintenance
Projects
DACS - student software dev board
Status: In Progress
Milestone
Rails Application Sprint
Development

Successfully merging a pull request may close this issue.

[#452] Remove pul-assets gem pulibrary/DSS
4 participants
@kevinreiss @sandbergja @christinach @vh8154